GNU bug report logs - #14909
Subject: 24.3; imag-dired key-bindings not working

Previous Next

Package: emacs;

Reported by: dieter <at> duenenhof-wilhelm.de

Date: Fri, 19 Jul 2013 15:28:02 UTC

Severity: normal

Merged with 15884

Found in version 24.3

Fixed in version 24.4

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #11 received at 14909 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Glenn Morris <rgm <at> gnu.org>
Cc: dieter <at> duenenhof-wilhelm.de, 14909 <at> debbugs.gnu.org
Subject: Re: bug#14909: Subject: 24.3; imag-dired key-bindings not working
Date: Sat, 20 Jul 2013 04:32:55 -0400

> !   (let* ((old-buf (current-buffer))
>            (dired-buf (image-dired-associated-dired-buffer))
> !          (file-name (image-dired-original-file-name))
> !          (window (image-dired-get-buffer-window dired-buf)))
>       (when (and (buffer-live-p dired-buf) file-name)
>         (set-buffer dired-buf)
>         (if (not (dired-goto-file file-name))
>             (message "Could not track file")
> !         (if window (set-window-point window (point))))
>         (set-buffer old-buf))))

I see this code could use with-current-buffer.


        Stefan
This bug report was last modified 11 years and 188 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.