GNU bug report logs - #14490
Error in specman-mode.el

Previous Next

Package: emacs;

Reported by: Ethan Berger <eberger <at> tilera.com>

Date: Tue, 28 May 2013 16:25:01 UTC

Severity: wishlist

Merged with 14458

Found in version 24.3

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14490 in the body.
You can then email your comments to 14490 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#14490; Package emacs. (Tue, 28 May 2013 16:25:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Ethan Berger <eberger <at> tilera.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 28 May 2013 16:25:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ethan Berger <eberger <at> tilera.com>
To: "'bug-gnu-emacs <at> gnu.org'" <bug-gnu-emacs <at> gnu.org>
Subject: Error in specman-mode.el
Date: Tue, 28 May 2013 15:56:57 +0000

The following code appears in revision 1.23 of specman-mode.el:

(defvar emacs-kind nil)

;; emacs or xemacs
(if (or (string-match "Lucid" emacs-version)
        (string-match "XEmacs" emacs-version))
    (setq specman-emacs-kind 'xemacs)
  (setq specman-emacs-kind 'emacs))

Elsewhere in the file there are references to emacs-kind, which is always nil, rather than to specman-emacs-kind.  Naturally, this causes other problems.
Forcibly Merged 14458 14490. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Tue, 28 May 2013 17:20:01 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14490; Package emacs. (Tue, 28 May 2013 17:21:02 GMT) Full text and rfc822 format available.

Message #10 received at 14490 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Ethan Berger <eberger <at> tilera.com>
Cc: 14490 <at> debbugs.gnu.org
Subject: Re: bug#14490: Error in specman-mode.el
Date: Tue, 28 May 2013 13:18:55 -0400

> ;; emacs or xemacs
> (if (or (string-match "Lucid" emacs-version)
>         (string-match "XEmacs" emacs-version))
>     (setq specman-emacs-kind 'xemacs)
>   (setq specman-emacs-kind 'emacs))

BTW, the standard recommended way to test is (featurep 'xemacs) and
rather than store the result in a variable, it's better to repeat the
test everywhere you need it, because the compiler will handle it more
efficiently (whereas if it's stored in a variable, the compiler won't be
able to tell that you'll never change the variable).


        Stefan
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 26 Jun 2013 11:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 11 years and 359 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.