GNU bug report logs - #14068
[PATCH] Officially support DragonFly BSD

Previous Next

Full log

Message #17 received at 14068 <at> debbugs.gnu.org (full text, mbox):

From: John Marino <gnugcc <at> marino.st>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 14068 <at> debbugs.gnu.org
Subject: Re: bug#14068: [PATCH] Officially support DragonFly BSD
Date: Thu, 18 Apr 2013 09:59:47 +0200

On 4/18/2013 07:46, Glenn Morris wrote:
> John Marino wrote:
>
>> The previously submitted patch was for release 24.3.
>> The patch to add DragonFly support to version 24.3.50.112178 is much
>> smaller:
>> https://raw.github.com/jrmarino/DPorts/staged/editors/emacs-devel/dragonfly/patch-configure.ac
>
> +     case "${canonical}" in
> +       i[3456]86-*-dragonfly*)     machine=intel386 ;;
> +       amd64-*-dragonfly*|x86_64-*-dragonfly*) machine=amdx86-64 ;;
> +     esac
>
> machine is no longer used, so these lines are unnecessary.


Okay, good to know!


>
> -   freebsd) LIBS_SYSTEM="-lutil" ;;
> +   freebsd|netbsd|openbsd|dragonfly) LIBS_SYSTEM="-lutil" ;;
>
> Why are you adding netbsd and openbsd as well?


It was likely left over from years.  The submitted patch came from 
pkgsrc and freebsd ports.  It is appropriate to only add DragonFly (as 
you have done) and let representatives from the other BSDs speak for 
themselves.


>
> Apart from that, it seems fine to me.
> It's probably just small enough not to need a copyright assignment; but
> for the ChangeLog, can you tell me who the author is?

I think it's reasonable to call me (John Marino) the primary author.  I 
basically had to create it from scratch -- most of this information was 
in those "S" files and had to be moved to the configure script, so it's 
basically new.

>
> Revised patch against current trunk:

With a quick glance, it looks good to me.
Thanks!

John

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.