GNU bug report logs - #14066
24.3; vc-bzr-revert shouldn't create backup files

Previous Next

Package: emacs;

Reported by: Leo Liu <sdl.web <at> gmail.com>

Date: Wed, 27 Mar 2013 15:43:03 UTC

Severity: normal

Found in version 24.3

Done: Leo Liu <sdl.web <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo Liu <sdl.web <at> gmail.com>
Subject: bug#14066: closed (Re: bug#14066: 24.3; vc-bzr-revert shouldn't
 create backup files)
Date: Thu, 28 Mar 2013 03:32:01 +0000

[Message part 1 (text/plain, inline)]
Your bug report

#14066: 24.3; vc-bzr-revert shouldn't create backup files

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 14066 <at> debbugs.gnu.org.

-- 
14066: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14066
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]
From: Leo Liu <sdl.web <at> gmail.com>
To: 14066-done <at> debbugs.gnu.org
Subject: Re: bug#14066: 24.3; vc-bzr-revert shouldn't create backup files
Date: Thu, 28 Mar 2013 11:29:23 +0800

Fixed in trunk


[Message part 3 (message/rfc822, inline)]
From: Leo Liu <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; vc-bzr-revert shouldn't create backup files
Date: Wed, 27 Mar 2013 23:36:53 +0800

According to vc-default-make-version-backups-p, no backup file is
created for the bzr backend. However 'bzr revert' itself creates backups
which is very confusing.

So I propose the following patch:

diff --git a/lisp/vc/vc-bzr.el b/lisp/vc/vc-bzr.el
index f436d300..c1195eee 100644
--- a/lisp/vc/vc-bzr.el
+++ b/lisp/vc/vc-bzr.el
@@ -644,7 +644,7 @@ (defun vc-bzr-checkout (_file &optional _editable rev)
 
 (defun vc-bzr-revert (file &optional contents-done)
   (unless contents-done
-    (with-temp-buffer (vc-bzr-command "revert" t 0 file))))
+    (with-temp-buffer (vc-bzr-command "revert" t 0 file "--no-backup"))))
 
 (defvar log-view-message-re)
 (defvar log-view-file-re)
This bug report was last modified 12 years and 117 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.