GNU bug report logs - #13981
24.3.50; Incorrect declaration of image_background

Previous Next

Full log

Message #8 received at 13981 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 13981 <at> debbugs.gnu.org
Subject: Re: bug#13981: 24.3.50; Incorrect declaration of image_background
Date: Sun, 17 Mar 2013 05:48:02 +0200

> Date: Sat, 16 Mar 2013 15:57:09 -0400
> From: Ken Brown <kbrown <at> cornell.edu>
> 
> image_background() is declared in dispextern.h with a return type of 
> `unsigned long'.  But it is defined in image.c with a return type of 
> RGB_PIXEL_COLOR, where the latter is a platform-dependent macro defined 
> in image.c.
> 
> By luck, this doesn't cause any problems in the currently-supported 
> platforms.  But it will cause problems in the cygw32 build on 64-bit 
> Cygwin (which is currently under development).  The attached patch fixes 
> this by moving the definition of RGB_PIXEL_COLOR to dispextern.h and 
> changing the return type in the declaration.
> 
> OK to apply?

Yes, but please move the definition of RGB_PIXEL_COLOR so it is just
before the prototype of image_background, since that is its only user.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.