GNU bug report logs - #13981
24.3.50; Incorrect declaration of image_background

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13981 in the body.
You can then email your comments to 13981 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; Incorrect declaration of image_background
Date: Sat, 16 Mar 2013 15:57:09 -0400

[Message part 1 (text/plain, inline)]

image_background() is declared in dispextern.h with a return type of 
`unsigned long'.  But it is defined in image.c with a return type of 
RGB_PIXEL_COLOR, where the latter is a platform-dependent macro defined 
in image.c.

By luck, this doesn't cause any problems in the currently-supported 
platforms.  But it will cause problems in the cygw32 build on 64-bit 
Cygwin (which is currently under development).  The attached patch fixes 
this by moving the definition of RGB_PIXEL_COLOR to dispextern.h and 
changing the return type in the declaration.

OK to apply?

Ken

[image_background.patch (text/plain, attachment)]

Message #8 received at 13981 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 13981 <at> debbugs.gnu.org
Subject: Re: bug#13981: 24.3.50; Incorrect declaration of image_background
Date: Sun, 17 Mar 2013 05:48:02 +0200

> Date: Sat, 16 Mar 2013 15:57:09 -0400
> From: Ken Brown <kbrown <at> cornell.edu>
> 
> image_background() is declared in dispextern.h with a return type of 
> `unsigned long'.  But it is defined in image.c with a return type of 
> RGB_PIXEL_COLOR, where the latter is a platform-dependent macro defined 
> in image.c.
> 
> By luck, this doesn't cause any problems in the currently-supported 
> platforms.  But it will cause problems in the cygw32 build on 64-bit 
> Cygwin (which is currently under development).  The attached patch fixes 
> this by moving the definition of RGB_PIXEL_COLOR to dispextern.h and 
> changing the return type in the declaration.
> 
> OK to apply?

Yes, but please move the definition of RGB_PIXEL_COLOR so it is just
before the prototype of image_background, since that is its only user.

Thanks.

Message #13 received at 13981-done <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 13981-done <at> debbugs.gnu.org
Subject: Re: bug#13981: 24.3.50; Incorrect declaration of image_background
Date: Sun, 17 Mar 2013 10:36:25 -0400

On 3/16/2013 11:48 PM, Eli Zaretskii wrote:
>> Date: Sat, 16 Mar 2013 15:57:09 -0400
>> From: Ken Brown <kbrown <at> cornell.edu>
>> OK to apply?
>
> Yes, but please move the definition of RGB_PIXEL_COLOR so it is just
> before the prototype of image_background, since that is its only user.

Done as bzr revision 112064.  I'm closing the bug.

Ken

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.