GNU bug report logs - #13981
24.3.50; Incorrect declaration of image_background

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ken Brown <kbrown <at> cornell.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#13981: closed (24.3.50; Incorrect declaration of
 image_background)
Date: Sun, 17 Mar 2013 14:39:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 17 Mar 2013 10:36:25 -0400
with message-id <5145D4E9.1020406 <at> cornell.edu>
and subject line Re: bug#13981: 24.3.50; Incorrect declaration of image_background
has caused the debbugs.gnu.org bug report #13981,
regarding 24.3.50; Incorrect declaration of image_background
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
13981: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13981
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ken Brown <kbrown <at> cornell.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; Incorrect declaration of image_background
Date: Sat, 16 Mar 2013 15:57:09 -0400

[Message part 3 (text/plain, inline)]

image_background() is declared in dispextern.h with a return type of 
`unsigned long'.  But it is defined in image.c with a return type of 
RGB_PIXEL_COLOR, where the latter is a platform-dependent macro defined 
in image.c.

By luck, this doesn't cause any problems in the currently-supported 
platforms.  But it will cause problems in the cygw32 build on 64-bit 
Cygwin (which is currently under development).  The attached patch fixes 
this by moving the definition of RGB_PIXEL_COLOR to dispextern.h and 
changing the return type in the declaration.

OK to apply?

Ken

[image_background.patch (text/plain, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Ken Brown <kbrown <at> cornell.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 13981-done <at> debbugs.gnu.org
Subject: Re: bug#13981: 24.3.50; Incorrect declaration of image_background
Date: Sun, 17 Mar 2013 10:36:25 -0400

On 3/16/2013 11:48 PM, Eli Zaretskii wrote:
>> Date: Sat, 16 Mar 2013 15:57:09 -0400
>> From: Ken Brown <kbrown <at> cornell.edu>
>> OK to apply?
>
> Yes, but please move the definition of RGB_PIXEL_COLOR so it is just
> before the prototype of image_background, since that is its only user.

Done as bzr revision 112064.  I'm closing the bug.

Ken

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.