GNU bug report logs - #13817
24.3.50; Disabling whitespace-mode that was enabled in sgml-mode-hook breaks font-lock

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dmitry Gutov <dgutov <at> yandex.ru>
Subject: bug#13817: closed (Re: bug#13817: 24.3.50; Disabling
 whitespace-mode that was enabled in sgml-mode-hook breaks font-lock)
Date: Tue, 19 Mar 2013 05:11:04 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#13817: 24.3.50; Disabling whitespace-mode that was enabled in sgml-mode-hook breaks font-lock

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 13817 <at> debbugs.gnu.org.

-- 
13817: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13817
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 13817-done <at> debbugs.gnu.org
Subject: Re: bug#13817: 24.3.50; Disabling whitespace-mode that was enabled
	in sgml-mode-hook breaks font-lock
Date: Tue, 19 Mar 2013 09:09:00 +0400

Version: 24.4

On 18.03.2013 2:30, Stefan Monnier wrote:
>> On the surface, the reason for this is that when whitespace-mode is being
>> turned on in the hook, font-lock-keywords is still nil, and so nil is
>> saved in whitespace-font-lock-keywords.
>
> whitespace.el should probably use font-lock-remove-keywords instead.

That helped, thank you.

I left the disabling/enabling of font-lock-mode there, because otherwise 
the changes in highlighting are not visible until the buffer is modified.

[Message part 3 (message/rfc822, inline)]

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50;
	Disabling whitespace-mode that was enabled in sgml-mode-hook breaks
	font-lock
Date: Tue, 26 Feb 2013 10:29:13 +0400

Revno 111881 fixed the obvious problem with whitespace-mode, here's a
less obvious one.

This seems to be localized to sgml-mode and its derivatives so far:
js-mode, ruby-mode, etc are not affected.

1. (add-hook 'sgml-mode-hook 'whitespace-mode)
2. Open a file in sgml-mode or html-mode, or create a buffer and turn
either mode manually. whitespace-mode will be enabled.
3. M-x whitespace-mode => it's disabled, font-lock is gone, the value of
font-lock-keywords is (t nil).

On the surface, the reason for this is that when whitespace-mode is being
turned on in the hook, font-lock-keywords is still nil, and so nil is
saved in whitespace-font-lock-keywords.

In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.6.0)
 of 2013-02-26 on vbx
Bzr revision: 111882 eggert <at> cs.ucla.edu-20130226030908-c65ivknn1bm5hjru
Windowing system distributor `The X.Org Foundation', version 11.0.11300000
System Description:	Ubuntu 12.10

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.