GNU bug report logs - #13816
24.3.50; turn-on-font-lock doesn't turn it on

Previous Next

Package: emacs;

Reported by: Katsumi Yamaoka <yamaoka <at> jpl.org>

Date: Tue, 26 Feb 2013 02:05:01 UTC

Severity: normal

Tags: confirmed, patch

Merged with 13730, 13751, 13806, 13812

Found in version 24.3.50

Done: Katsumi Yamaoka <yamaoka <at> jpl.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13816 in the body.
You can then email your comments to 13816 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#13816; Package emacs. (Tue, 26 Feb 2013 02:05:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Katsumi Yamaoka <yamaoka <at> jpl.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 26 Feb 2013 02:05:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; turn-on-font-lock doesn't turn it on
Date: Tue, 26 Feb 2013 11:02:12 +0900

Recently turn-on-font-lock set to some hook turns font-lock
on but turns it off immediately regardless of the value of
global-font-lock-mode.  Here's a recipe:

emacs -Q
Eval: (add-hook 'emacs-lisp-mode-hook 'turn-on-font-lock)
and visit some .el file.

In Emacs 24.2, it works no matter what global-font-lock-mode is.
Thanks.
Merged 13730 13751 13806 13812 13816. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Tue, 26 Feb 2013 02:20:03 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#13816; Package emacs. (Tue, 26 Feb 2013 03:04:01 GMT) Full text and rfc822 format available.

Message #10 received at 13816 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: 13816 <at> debbugs.gnu.org
Subject: Re: bug#13816: 24.3.50; turn-on-font-lock doesn't turn it on
Date: Mon, 25 Feb 2013 22:01:59 -0500

> Recently turn-on-font-lock set to some hook turns font-lock
> on but turns it off immediately regardless of the value of
> global-font-lock-mode.  Here's a recipe:

> emacs -Q
> Eval: (add-hook 'emacs-lisp-mode-hook 'turn-on-font-lock)
> and visit some .el file.

Works fine on the trunk right now.  Can you confirm it was fixed if you
try a recent enough build?


        Stefan
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#13816; Package emacs. (Tue, 26 Feb 2013 06:08:02 GMT) Full text and rfc822 format available.

Message #13 received at 13816 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Stefan Monnier'" <monnier <at> iro.umontreal.ca>,
	"'Katsumi Yamaoka'" <yamaoka <at> jpl.org>
Cc: 13816 <at> debbugs.gnu.org
Subject: RE: bug#13816: 24.3.50; turn-on-font-lock doesn't turn it on
Date: Mon, 25 Feb 2013 22:05:51 -0800

> > Recently turn-on-font-lock set to some hook turns font-lock
> > on but turns it off immediately regardless of the value of
> > global-font-lock-mode.  Here's a recipe:
> 
> > emacs -Q
> > Eval: (add-hook 'emacs-lisp-mode-hook 'turn-on-font-lock)
> > and visit some .el file.
> 
> Works fine on the trunk right now.  Can you confirm it was 
> fixed if you try a recent enough build?

The recent font-lock breakage is still there - it still does not work as of this
trunk build, today:

In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
 of 2013-02-25 on ODIEONE
Bzr revision: 111879 yamaoka <at> jpl.org-20130225224731-cv9gznq5nqf3ei7g
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
 -IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib'

In particular, see bug #13767 (no `&optional' highlighting) and bug #13755 (see
screenshots).

However, bug #13751 seems to be fixed, at first sight, at least.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#13816; Package emacs. (Tue, 26 Feb 2013 06:48:01 GMT) Full text and rfc822 format available.

Message #16 received at 13816 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 'Katsumi Yamaoka' <yamaoka <at> jpl.org>, 13816 <at> debbugs.gnu.org,
	'Stefan Monnier' <monnier <at> iro.umontreal.ca>
Subject: Re: bug#13816: 24.3.50; turn-on-font-lock doesn't turn it on
Date: Tue, 26 Feb 2013 10:45:48 +0400

"Drew Adams" <drew.adams <at> oracle.com> writes:

>> > Recently turn-on-font-lock set to some hook turns font-lock
>> > on but turns it off immediately regardless of the value of
>> > global-font-lock-mode.  Here's a recipe:
>> 
>> > emacs -Q
>> > Eval: (add-hook 'emacs-lisp-mode-hook 'turn-on-font-lock)
>> > and visit some .el file.
>> 
>> Works fine on the trunk right now.  Can you confirm it was 
>> fixed if you try a recent enough build?
>
> The recent font-lock breakage is still there - it still does not work as of this
> trunk build, today:
>
> In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
>  of 2013-02-25 on ODIEONE
> Bzr revision: 111879 yamaoka <at> jpl.org-20130225224731-cv9gznq5nqf3ei7g
> Windowing system distributor `Microsoft Corp.', version 5.1.2600
> Configured using:
>  `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
>  -IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib'
>
> In particular, see bug #13767 (no `&optional' highlighting) and bug #13755 (see
> screenshots).
>
> However, bug #13751 seems to be fixed, at first sight, at least.

I also experienced font-lock-mode not turning on, and it was caused by
whitespace-mode. That part has been fixed in revision 111881.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#13816; Package emacs. (Tue, 26 Feb 2013 07:32:02 GMT) Full text and rfc822 format available.

Message #19 received at 13816 <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 13816 <at> debbugs.gnu.org
Subject: Re: bug#13816: 24.3.50; turn-on-font-lock doesn't turn it on
Date: Tue, 26 Feb 2013 16:29:25 +0900

Stefan Monnier wrote:
>> Recently turn-on-font-lock set to some hook turns font-lock
>> on but turns it off immediately regardless of the value of
>> global-font-lock-mode.  Here's a recipe:

>> emacs -Q
>> Eval: (add-hook 'emacs-lisp-mode-hook 'turn-on-font-lock)
>> and visit some .el file.

> Works fine on the trunk right now.  Can you confirm it was fixed if you
> try a recent enough build?

I build Emacs from the trunk almost everyday.  Now I use:

In GNU Emacs 24.3.50.1 (i686-pc-cygwin, X toolkit, Xaw3d scroll bars)
 of 2013-02-26 on localhost
Bzr revision: 111880 monnier <at> iro.umontreal.ca-20130225232750-8wmx78e4uz1u7tfk
Windowing system distributor `The Cygwin/X Project', version 11.0.11302000
Configured using:
 `configure --verbose --with-x-toolkit=lucid --without-imagemagick
 --without-dbus --without-gconf --without-gsettings'

I've reverted the 111870 change because of bug#13818, though.

According to my tracing of run-mode-hooks, it turns on font-lock
but turns it off by the last line:

(defun run-mode-hooks (&rest hooks)
[...]
    ;; ON
    (apply 'run-hooks (cons 'change-major-mode-after-body-hook hooks))
    ;; OFF
    (run-hooks 'after-change-major-mode-hook)))
Reply sent to Katsumi Yamaoka <yamaoka <at> jpl.org>:
You have taken responsibility. (Tue, 26 Feb 2013 07:54:03 GMT) Full text and rfc822 format available.
Notification sent to Katsumi Yamaoka <yamaoka <at> jpl.org>:
bug acknowledged by developer. (Tue, 26 Feb 2013 07:54:03 GMT) Full text and rfc822 format available.

Message #24 received at 13816-done <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: 13816-done <at> debbugs.gnu.org
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#13816: 24.3.50; turn-on-font-lock doesn't turn it on
Date: Tue, 26 Feb 2013 16:51:10 +0900

I confirmed it has been fixed on:

In GNU Emacs 24.3.50.1 (i686-pc-cygwin, X toolkit, Xaw3d scroll bars)
 of 2013-02-26 on yamaoka-PC
Bzr revision: 111882 eggert <at> cs.ucla.edu-20130226030908-c65ivknn1bm5hjru
Windowing system distributor `The Cygwin/X Project', version 11.0.11302000

Sorry for the noise.

Katsumi Yamaoka wrote:
> Stefan Monnier wrote:
>>> Recently turn-on-font-lock set to some hook turns font-lock
>>> on but turns it off immediately regardless of the value of
>>> global-font-lock-mode.  Here's a recipe:

>>> emacs -Q
>>> Eval: (add-hook 'emacs-lisp-mode-hook 'turn-on-font-lock)
>>> and visit some .el file.

>> Works fine on the trunk right now.  Can you confirm it was fixed if you
>> try a recent enough build?

> I build Emacs from the trunk almost everyday.  Now I use:

> In GNU Emacs 24.3.50.1 (i686-pc-cygwin, X toolkit, Xaw3d scroll bars)
>  of 2013-02-26 on localhost
> Bzr revision: 111880 monnier <at> iro.umontreal.ca-20130225232750-8wmx78e4uz1u7tfk
> Windowing system distributor `The Cygwin/X Project', version 11.0.11302000
> Configured using:
>  `configure --verbose --with-x-toolkit=lucid --without-imagemagick
>  --without-dbus --without-gconf --without-gsettings'

> I've reverted the 111870 change because of bug#13818, though.

> According to my tracing of run-mode-hooks, it turns on font-lock
> but turns it off by the last line:

> (defun run-mode-hooks (&rest hooks)
> [...]
>     ;; ON
>     (apply 'run-hooks (cons 'change-major-mode-after-body-hook hooks))
>     ;; OFF
>     (run-hooks 'after-change-major-mode-hook)))
Reply sent to Katsumi Yamaoka <yamaoka <at> jpl.org>:
You have taken responsibility. (Tue, 26 Feb 2013 07:54:03 GMT) Full text and rfc822 format available.
Notification sent to <rcopley <at> gmail.com>:
bug acknowledged by developer. (Tue, 26 Feb 2013 07:54:03 GMT) Full text and rfc822 format available.
Reply sent to Katsumi Yamaoka <yamaoka <at> jpl.org>:
You have taken responsibility. (Tue, 26 Feb 2013 07:54:03 GMT) Full text and rfc822 format available.
Notification sent to "Drew Adams" <drew.adams <at> oracle.com>:
bug acknowledged by developer. (Tue, 26 Feb 2013 07:54:03 GMT) Full text and rfc822 format available.
Reply sent to Katsumi Yamaoka <yamaoka <at> jpl.org>:
You have taken responsibility. (Tue, 26 Feb 2013 07:54:03 GMT) Full text and rfc822 format available.
Notification sent to Suvayu Ali <fatkasuvayu+linux <at> gmail.com>:
bug acknowledged by developer. (Tue, 26 Feb 2013 07:54:03 GMT) Full text and rfc822 format available.
Reply sent to Katsumi Yamaoka <yamaoka <at> jpl.org>:
You have taken responsibility. (Tue, 26 Feb 2013 07:54:04 GMT) Full text and rfc822 format available.
Notification sent to sds <at> gnu.org:
bug acknowledged by developer. (Tue, 26 Feb 2013 07:54:04 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#13816; Package emacs. (Tue, 26 Feb 2013 14:07:02 GMT) Full text and rfc822 format available.

Message #47 received at 13816-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: 13816-done <at> debbugs.gnu.org
Subject: Re: bug#13816: 24.3.50; turn-on-font-lock doesn't turn it on
Date: Tue, 26 Feb 2013 09:04:54 -0500

> I confirmed it has been fixed on:
> In GNU Emacs 24.3.50.1 (i686-pc-cygwin, X toolkit, Xaw3d scroll bars)
>  of 2013-02-26 on yamaoka-PC
> Bzr revision: 111882 eggert <at> cs.ucla.edu-20130226030908-c65ivknn1bm5hjru
> Windowing system distributor `The Cygwin/X Project', version 11.0.11302000
> Sorry for the noise.

Thanks for the noise ;-)


        Stefan
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 27 Mar 2013 11:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 12 years and 90 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.