GNU bug report logs - #13380
24.2.91; Annoying change to cvs-cleanup-collection

Previous Next

Full log

Message #11 received at 13380 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: storm <at> cua.dk (Kim F. Storm)
Cc: 13380 <at> debbugs.gnu.org
Subject: Re: bug#13380: 24.2.91; Annoying change to cvs-cleanup-collection
Date: Tue, 08 Jan 2013 12:36:15 -0500

> The following change is just SO annoying.
> I'm accustomed to using 'x' in the *cvs* buffer to get rid of
> all the files that need attention -- but with this change,
> it is practically random what is kept and what is removed.

Oh, it was not meant to affect `x', indeed.  I just installed the patch
below which should fix it.


        Stefan


=== modified file 'lisp/vc/pcvs.el'
--- lisp/vc/pcvs.el	2013-01-01 09:11:05 +0000
+++ lisp/vc/pcvs.el	2013-01-08 17:29:57 +0000
@@ -876,9 +876,10 @@
 		     (`DEAD nil)
 		     ;; handled also?
 		     (`UP-TO-DATE
+                      (not
                       (if (find-buffer-visiting (cvs-fileinfo->full-name fi))
-                          t
-                        (not rm-handled)))
+                           (eq rm-handled 'all)
+                         rm-handled)))
 		     ;; keep the rest
 		     (_ (not (run-hook-with-args-until-success
 			      'cvs-cleanup-functions fi))))))
@@ -2121,7 +2122,7 @@
 Empty directories are removed."
   (interactive)
   (cvs-cleanup-collection cvs-cookies
-			  t (or cvs-auto-remove-directories 'handled) t))
+			  'all (or cvs-auto-remove-directories 'handled) t))
 
 
 (defun-cvs-mode cvs-mode-acknowledge ()

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.