GNU bug report logs - #13380
24.2.91; Annoying change to cvs-cleanup-collection

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13380 in the body.
You can then email your comments to 13380 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: storm <at> cua.dk (Kim F. Storm)
To: bug-gnu-emacs <at> gnu.org
Subject: 24.2.91; Annoying change to cvs-cleanup-collection
Date: Mon, 07 Jan 2013 15:50:54 -0500

The following change is just SO annoying.
I'm accustomed to using 'x' in the *cvs* buffer to get rid of
all the files that need attention -- but with this change,
it is practically random what is kept and what is removed.

2012-09-30  Stefan Monnier  <monnier <at> iro.umontreal.ca>

	* vc/pcvs.el (cvs-cleanup-collection): Keep entries that are currently
	visited in a buffer.

Could we at least have it as an option, -- thank you.


In GNU Emacs 24.2.91.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2)
 of 2013-01-02 on kfs-lx2
Windowing system distributor `The X.Org Foundation', version 11.0.11104000
System Description:	Debian GNU/Linux 6.0.6 (squeeze)

-- 
Kim F. Storm  <storm <at> cua.dk>      http://www.cua.dk

Message #8 received at 13380 <at> debbugs.gnu.org (full text, mbox):

From: Kim Storm <storm <at> cua.dk>
To: 13380 <at> debbugs.gnu.org
Subject: Re: bug#13380: Acknowledgement (24.2.91;
	Annoying change to cvs-cleanup-collection)
Date: Mon, 07 Jan 2013 21:59:23 +0100

Of course, what I meant was

I'm accustomed to using 'x' in the *cvs* buffer to get rid of
all the entries that _DON'T_ need attention -- but with this change,
it is practically random what is kept and what is removed.


Kim

Message #11 received at 13380 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: storm <at> cua.dk (Kim F. Storm)
Cc: 13380 <at> debbugs.gnu.org
Subject: Re: bug#13380: 24.2.91; Annoying change to cvs-cleanup-collection
Date: Tue, 08 Jan 2013 12:36:15 -0500

> The following change is just SO annoying.
> I'm accustomed to using 'x' in the *cvs* buffer to get rid of
> all the files that need attention -- but with this change,
> it is practically random what is kept and what is removed.

Oh, it was not meant to affect `x', indeed.  I just installed the patch
below which should fix it.


        Stefan


=== modified file 'lisp/vc/pcvs.el'
--- lisp/vc/pcvs.el	2013-01-01 09:11:05 +0000
+++ lisp/vc/pcvs.el	2013-01-08 17:29:57 +0000
@@ -876,9 +876,10 @@
 		     (`DEAD nil)
 		     ;; handled also?
 		     (`UP-TO-DATE
+                      (not
                       (if (find-buffer-visiting (cvs-fileinfo->full-name fi))
-                          t
-                        (not rm-handled)))
+                           (eq rm-handled 'all)
+                         rm-handled)))
 		     ;; keep the rest
 		     (_ (not (run-hook-with-args-until-success
 			      'cvs-cleanup-functions fi))))))
@@ -2121,7 +2122,7 @@
 Empty directories are removed."
   (interactive)
   (cvs-cleanup-collection cvs-cookies
-			  t (or cvs-auto-remove-directories 'handled) t))
+			  'all (or cvs-auto-remove-directories 'handled) t))
 
 
 (defun-cvs-mode cvs-mode-acknowledge ()

Message #14 received at 13380 <at> debbugs.gnu.org (full text, mbox):

From: Kim Storm <storm <at> cua.dk>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 13380 <at> debbugs.gnu.org
Subject: Re: bug#13380: 24.2.91; Annoying change to cvs-cleanup-collection
Date: Tue, 08 Jan 2013 19:35:19 +0100

On 2013-01-08 18:36, Stefan Monnier wrote:
>> The following change is just SO annoying.
>> I'm accustomed to using 'x' in the *cvs* buffer to get rid of
>> all the files that need attention -- but with this change,
>> it is practically random what is kept and what is removed.
> Oh, it was not meant to affect `x', indeed.  I just installed the patch
> below which should fix it.
>


Yes, that fixes it.

Thank you

Kim

Message #19 received at 13380-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Kim Storm <storm <at> cua.dk>
Cc: 13380-done <at> debbugs.gnu.org
Subject: Re: bug#13380: 24.2.91; Annoying change to cvs-cleanup-collection
Date: Tue, 08 Jan 2013 16:07:10 -0500

> Yes, that fixes it.
> Thank you

Great, thanks, closing,


        Stefan "we're missing you here"

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.