GNU bug report logs - #13169
[PATCH] kill-region fails to deactivate mark after cutting empty region

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Chong Yidong <cyd <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#13169: closed ([PATCH] kill-region fails to deactivate mark
 after cutting empty region)
Date: Fri, 21 Dec 2012 03:51:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 21 Dec 2012 11:49:54 +0800
with message-id <874njgcbdp.fsf <at> gnu.org>
and subject line Re: bug#13169: [PATCH] kill-region fails to deactivate mark after cutting empty region
has caused the debbugs.gnu.org bug report #13169,
regarding [PATCH] kill-region fails to deactivate mark after cutting empty region
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
13169: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13169
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Kelly Dean <kellydeanch <at> yahoo.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] kill-region fails to deactivate mark after cutting empty
	region
Date: Thu, 13 Dec 2012 00:19:16 -0800 (PST)

[Message part 3 (text/plain, inline)]

On 24.2, emacs -Q
C-SPC M-w C-p
kill-ring-save copied an empty region, and deactivated the mark. This is correct. But now do
C-SPC C-w C-p
kill-region cut an empty region, which is correct, but the mark is still active, which is incorrect. When the buffer and text aren't read-only, kill-region relies on the command loop to deactivate the mark after the buffer is modified, but when cutting an empty region, the buffer isn't modified, so the mark is never deactivated.
The attached killregionbug.patch fixes it.

[killregionbug.patch (text/x-diff, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Chong Yidong <cyd <at> gnu.org>
To: Kelly Dean <kellydeanch <at> yahoo.com>
Cc: 13169-done <at> debbugs.gnu.org
Subject: Re: bug#13169: [PATCH] kill-region fails to deactivate mark after
	cutting empty region
Date: Fri, 21 Dec 2012 11:49:54 +0800

Kelly Dean <kellydeanch <at> yahoo.com> writes:

> C-SPC C-w C-p
> kill-region cut an empty region, which is correct, but the mark is
> still active, which is incorrect. When the buffer and text aren't
> read-only, kill-region relies on the command loop to deactivate the
> mark after the buffer is modified, but when cutting an empty region,
> the buffer isn't modified, so the mark is never deactivated.
> The attached killregionbug.patch fixes it.

Committed to trunk, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.