GNU bug report logs - #13169
[PATCH] kill-region fails to deactivate mark after cutting empty region

Previous Next

Package: emacs;

Reported by: Kelly Dean <kellydeanch <at> yahoo.com>

Date: Thu, 13 Dec 2012 08:21:01 UTC

Severity: normal

Tags: patch

Done: Chong Yidong <cyd <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13169 in the body.
You can then email your comments to 13169 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#13169; Package emacs. (Thu, 13 Dec 2012 08:21:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Kelly Dean <kellydeanch <at> yahoo.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 13 Dec 2012 08:21:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kelly Dean <kellydeanch <at> yahoo.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] kill-region fails to deactivate mark after cutting empty
	region
Date: Thu, 13 Dec 2012 00:19:16 -0800 (PST)

[Message part 1 (text/plain, inline)]
On 24.2, emacs -Q
C-SPC M-w C-p
kill-ring-save copied an empty region, and deactivated the mark. This is correct. But now do
C-SPC C-w C-p
kill-region cut an empty region, which is correct, but the mark is still active, which is incorrect. When the buffer and text aren't read-only, kill-region relies on the command loop to deactivate the mark after the buffer is modified, but when cutting an empty region, the buffer isn't modified, so the mark is never deactivated.
The attached killregionbug.patch fixes it.
[killregionbug.patch (text/x-diff, attachment)]
Reply sent to Chong Yidong <cyd <at> gnu.org>:
You have taken responsibility. (Fri, 21 Dec 2012 03:51:02 GMT) Full text and rfc822 format available.
Notification sent to Kelly Dean <kellydeanch <at> yahoo.com>:
bug acknowledged by developer. (Fri, 21 Dec 2012 03:51:02 GMT) Full text and rfc822 format available.

Message #10 received at 13169-done <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: Kelly Dean <kellydeanch <at> yahoo.com>
Cc: 13169-done <at> debbugs.gnu.org
Subject: Re: bug#13169: [PATCH] kill-region fails to deactivate mark after
	cutting empty region
Date: Fri, 21 Dec 2012 11:49:54 +0800

Kelly Dean <kellydeanch <at> yahoo.com> writes:

> C-SPC C-w C-p
> kill-region cut an empty region, which is correct, but the mark is
> still active, which is incorrect. When the buffer and text aren't
> read-only, kill-region relies on the command loop to deactivate the
> mark after the buffer is modified, but when cutting an empty region,
> the buffer isn't modified, so the mark is never deactivated.
> The attached killregionbug.patch fixes it.

Committed to trunk, thanks.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 18 Jan 2013 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 12 years and 150 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.