GNU bug report logs - #1315
uniquify-buffer-name bug on save

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 1315 in the body.
You can then email your comments to 1315 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Reuben Thomas <rrt <at> sc3d.org>
To: bug-emacs <at> gnu.org
Subject: uniquify-buffer-name bug on save
Date: Fri, 7 Nov 2008 23:32:38 +0100 (CET)

Using an Emacs snapshot from Ubuntu (package version 1:20081013-1, which 
is presumably the date of the CVS snapshot).

When I save a buffer in a different directory but the same name, the path is 
not re-uniquified, which means it confusingly bears parts of the old path.

-- 
http://rrt.sc3d.org/
sane, a.  having tragedy in the heart and comedy in the head (Chesterton)

Message #8 received at 1315 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Reuben Thomas <rrt <at> sc3d.org>
Cc: 1315 <at> debbugs.gnu.org
Subject: Re: bug#1315: uniquify-buffer-name bug on save
Date: Sat, 08 Nov 2008 15:27:46 -0500

tags 1315 unreproducible,moreinfo
stop

Reuben Thomas wrote:

> When I save a buffer in a different directory but the same name, the path is 
> not re-uniquified, which means it confusingly bears parts of the old path.

Details are lacking, and I cannot reproduce this. I did:

./src/emacs -Q -l uniquify \
  --eval "(setq uniquify-buffer-name-style 'forward)" ./README ./etc/README

and I got two buffers names "etc/README" and "trunk/README".

In the latter, I did

C-x w /tmp/README

The name of the buffer changed to /tmp/README.

So please give a recipe starting from emacs -Q showing your problem.

Message #15 received at 1315 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Reuben Thomas <rrt <at> sc3d.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 1315 <at> debbugs.gnu.org
Subject: Re: bug#1315: uniquify-buffer-name bug on save
Date: Sat, 8 Nov 2008 23:15:53 +0100 (CET)

On Sat, 8 Nov 2008, Glenn Morris wrote:

> So please give a recipe starting from emacs -Q showing your problem.

emacs -Q -l uniquify   --eval "(setq uniquify-buffer-name-style 'forward)" 
--eval "(setq uniquify-after-kill-buffer-p nil)" /usr/bin/run-mailcap 
/usr/local/bin/run-mailcap

I then C-x w ~/run-mailcap

and the name is not changed. I presume this is because of the setting of 
uniquify-after-kill-buffer-p, but I didn't kill a buffer, I saved it.

-- 
http://rrt.sc3d.org/ | What you don't know controls you

Message #20 received at 1315 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Reuben Thomas <rrt <at> sc3d.org>
Cc: 1315 <at> debbugs.gnu.org
Subject: Re: bug#1315: uniquify-buffer-name bug on save
Date: Thu, 13 Nov 2008 04:09:22 -0500

Please try this (lightly tested) patch against CVS trunk:

*** uniquify.el.~1.75.~	2008-07-01 20:02:50.000000000 -0700
--- uniquify.el	2008-11-13 00:57:08.000000000 -0800
***************
*** 427,448 ****
  
  ;;; Hooks from the rest of Emacs
  
  ;; Buffer deletion
  ;; Rerationalize after a buffer is killed, to reduce coinciding buffer names.
  ;; This mechanism uses `kill-buffer-hook', which runs *before* deletion, so
  ;; it calls `uniquify-rerationalize-w/o-cb' to rerationalize the buffer list
  ;; ignoring the current buffer (which is going to be deleted anyway).
! (defun uniquify-maybe-rerationalize-w/o-cb ()
    "Re-rationalize buffer names, ignoring current buffer.
  For use on `kill-buffer-hook'."
!   (if (and (cdr uniquify-managed)
! 	   uniquify-buffer-name-style
! 	   uniquify-after-kill-buffer-p)
!       (uniquify-rerationalize-w/o-cb uniquify-managed)))
  
  ;; Ideally we'd like to add it buffer-locally, but that doesn't work
  ;; because kill-buffer-hook is not permanent-local :-(
! (add-hook 'kill-buffer-hook 'uniquify-maybe-rerationalize-w/o-cb)
  
  ;; The logical place to put all this code is in generate-new-buffer-name.
  ;; It's written in C, so we would add a generate-new-buffer-name-function
--- 427,452 ----
  
  ;;; Hooks from the rest of Emacs
  
+ (defun uniquify-maybe-rerationalize-w/o-cb ()
+   "Re-rationalize buffer names, ignoring current buffer."
+   (and (cdr uniquify-managed)
+        uniquify-buffer-name-style
+        (uniquify-rerationalize-w/o-cb uniquify-managed)))
+ 
  ;; Buffer deletion
  ;; Rerationalize after a buffer is killed, to reduce coinciding buffer names.
  ;; This mechanism uses `kill-buffer-hook', which runs *before* deletion, so
  ;; it calls `uniquify-rerationalize-w/o-cb' to rerationalize the buffer list
  ;; ignoring the current buffer (which is going to be deleted anyway).
! (defun uniquify-kill-buffer-function ()
    "Re-rationalize buffer names, ignoring current buffer.
  For use on `kill-buffer-hook'."
!   (and uniquify-after-kill-buffer-p
!        (uniquify-maybe-rerationalize-w/o-cb)))
  
  ;; Ideally we'd like to add it buffer-locally, but that doesn't work
  ;; because kill-buffer-hook is not permanent-local :-(
! (add-hook 'kill-buffer-hook 'uniquify-kill-buffer-function)
  
  ;; The logical place to put all this code is in generate-new-buffer-name.
  ;; It's written in C, so we would add a generate-new-buffer-name-function

Message #25 received at 1315 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Reuben Thomas <rrt <at> sc3d.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 1315 <at> debbugs.gnu.org
Subject: Re: bug#1315: uniquify-buffer-name bug on save
Date: Thu, 13 Nov 2008 23:24:46 +0100 (CET)

On Thu, 13 Nov 2008, Glenn Morris wrote:

> Please try this (lightly tested) patch against CVS trunk:

Ace, works for me, doing the same test as before. I will copy the patched 
uniquify.el into my working Emacs tree and report if I get any problems.

Thanks!

-- 
http://rrt.sc3d.org/ | Troy is in the Iliad, not in the sand (A. N. Wilson)

Message #30 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: bojohan+news <at> dd.chalmers.se (Johan Bockgård)
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#1315: uniquify-buffer-name bug on save
Date: Thu, 13 Nov 2008 23:35:10 +0100

Glenn Morris <rgm <at> gnu.org> writes:

>   ;; Ideally we'd like to add it buffer-locally, but that doesn't work
>   ;; because kill-buffer-hook is not permanent-local :-(

It is now.

Message #35 received at 1315-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 1315-done <at> debbugs.gnu.org
Subject: Re: bug#1315: uniquify-buffer-name bug on save
Date: Sat, 15 Nov 2008 17:34:47 -0500

2008-11-15  Glenn Morris  <rgm <at> gnu.org>

    * uniquify.el (uniquify-maybe-rerationalize-w/o-cb):
    Remove uniquify-after-kill-buffer-p dependency.
    (uniquify-kill-buffer-function): New function.
    (kill-buffer-hook): Use uniquify-kill-buffer-function.  (Bug#1315)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.