GNU bug report logs - #13085
24.3.50; (invalid-function internal--called-interactively-p--get-frame)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13085 in the body.
You can then email your comments to 13085 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.3.50;
	(invalid-function internal--called-interactively-p--get-frame)
Date: Tue, 4 Dec 2012 16:44:53 -0800

(defadvice narrow-to-region (before foo activate)
  "..."
  (interactive-p))
 
M-x ad-activate foo  ; Why is this necessary?
 
M-x set-variable debug-on-error t
 
C-x n n ; Then you get the backtrace:
 
Debugger entered--Lisp error: (invalid-function
internal--called-interactively-p--get-frame)
  internal--called-interactively-p--get-frame(5)
  #[771 "..." [internal--called-interactively-p--get-frame] 6 "\n\n(fn FRAME1
FRAME2 I)"](((t apply ad-Advice-narrow-to-region #<subr narrow-to-region> (192
262))) ((t apply ad-Advice-narrow-to-region #<subr narrow-to-region> (192 262)))
(5))
  advice--called-interactively-skip(5 (t ad-Advice-narrow-to-region #<subr
narrow-to-region> 192 262) (t apply ad-Advice-narrow-to-region #<subr
narrow-to-region> (192 262)))
  run-hook-with-args-until-success(advice--called-interactively-skip 5 (t
ad-Advice-narrow-to-region #<subr narrow-to-region> 192 262) (t apply
ad-Advice-narrow-to-region #<subr narrow-to-region> (192 262)))
  called-interactively-p(interactive)
  interactive-p()
  (let (ad-return-value) (interactive-p) (setq ad-return-value (with-no-warnings
(funcall ad--addoit-function start end))) ad-return-value)
  ad-Advice-narrow-to-region(#<subr narrow-to-region> 192 262)
  apply(ad-Advice-narrow-to-region #<subr narrow-to-region> (192 262))
  narrow-to-region(192 262)
  call-interactively(narrow-to-region nil nil)
 
In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
 of 2012-12-03 on MS-W7-DANI
Bzr revision: 111077
agustin.martin <at> hispalinux.es-20121203172342-ifsebjmhksk28qa9
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
 -Ic:/emacs/libs/libXpm-3.5.10/include -Ic:/emacs/libs/libXpm-3.5.10/src
 -Ic:/emacs/libs/libpng-1.2.37-lib/include -Ic:/emacs/libs/zlib-1.2.5
 -Ic:/emacs/libs/giflib-4.1.4-1-lib/include
 -Ic:/emacs/libs/jpeg-6b-4-lib/include
 -Ic:/emacs/libs/tiff-3.8.2-1-lib/include
 -Ic:/emacs/libs/libxml2-2.7.8-w32-bin/include/libxml2
 -Ic:/emacs/libs/gnutls-3.0.9-w32-bin/include
 -Ic:/emacs/libs/libiconv-1.9.2-1-lib/include'

Message #8 received at 13085 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 13085 <at> debbugs.gnu.org
Subject: Re: bug#13085: 24.3.50;
	(invalid-function internal--called-interactively-p--get-frame)
Date: Tue, 04 Dec 2012 23:13:51 -0500

> Debugger entered--Lisp error: (invalid-function
> internal--called-interactively-p--get-frame)
>   internal--called-interactively-p--get-frame(5)
>   #[771 "..." [internal--called-interactively-p--get-frame] 6 "\n\n(fn FRAME1
> FRAME2 I)"](((t apply ad-Advice-narrow-to-region #<subr narrow-to-region> (192
> 262))) ((t apply ad-Advice-narrow-to-region #<subr narrow-to-region> (192 262)))
> (5))
>   advice--called-interactively-skip(5 (t ad-Advice-narrow-to-region #<subr narrow-to-region> 192 262) (t apply ad-Advice-narrow-to-region #<subr narrow-to-region> (192 262)))

It looks like your nadvice.el was miscompiled, or compiled with an Emacs
that had an old subr.el (one without the
internal--called-interactively-p--get-frame macro).

My own bootstrapped `emacs' does not suffer from this problem, so I'm
not sure what caused this problem.


        Stefan

Message #11 received at 13085 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Stefan Monnier'" <monnier <at> iro.umontreal.ca>
Cc: 13085 <at> debbugs.gnu.org
Subject: RE: bug#13085: 24.3.50;
	(invalid-function internal--called-interactively-p--get-frame)
Date: Tue, 4 Dec 2012 20:19:18 -0800

> It looks like your nadvice.el was miscompiled, or compiled 
> with an Emacs that had an old subr.el (one without the
> internal--called-interactively-p--get-frame macro).
> 
> My own bootstrapped `emacs' does not suffer from this problem, so I'm
> not sure what caused this problem.

OK, but my nadvice.elc is the one delivered with the Emacs binary I downloaded.
I did not compile nadvice.el myself.  See the build info in the original report.
HTH.

Message #14 received at 13085 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 13085 <at> debbugs.gnu.org
Subject: Re: bug#13085: 24.3.50;
	(invalid-function internal--called-interactively-p--get-frame)
Date: Tue, 04 Dec 2012 23:59:27 -0500

> OK, but my nadvice.elc is the one delivered with the Emacs binary
> I downloaded.  I did not compile nadvice.el myself.

I kind of guessed it, but that just pushes the question elsewhere.
IOW, we need to hear from those who built this binary.


        Stefan

Message #17 received at 13085 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Stefan Monnier'" <monnier <at> iro.umontreal.ca>,
	"'Dani Moncayo'" <dmoncayo <at> gmail.com>
Cc: 13085 <at> debbugs.gnu.org
Subject: RE: bug#13085: 24.3.50;
	(invalid-function internal--called-interactively-p--get-frame)
Date: Fri, 7 Dec 2012 09:27:51 -0800

> > OK, but my nadvice.elc is the one delivered with the Emacs binary
> > I downloaded.  I did not compile nadvice.el myself.
> 
> I kind of guessed it, but that just pushes the question elsewhere.
> IOW, we need to hear from those who built this binary.

Any chance we could get a new Windows binary without this problem soon?  This
one is unusable.

Message #20 received at 13085 <at> debbugs.gnu.org (full text, mbox):

From: Dani Moncayo <dmoncayo <at> gmail.com>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 13085 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#13085: 24.3.50;
	(invalid-function internal--called-interactively-p--get-frame)
Date: Fri, 7 Dec 2012 19:40:02 +0100

>> > OK, but my nadvice.elc is the one delivered with the Emacs binary
>> > I downloaded.  I did not compile nadvice.el myself.
>>
>> I kind of guessed it, but that just pushes the question elsewhere.
>> IOW, we need to hear from those who built this binary.
>
> Any chance we could get a new Windows binary without this problem soon?  This
> one is unusable.

Probably, I'll upload a new build on Monday.

FWIW:
* I've not bootstrapped Emacs for a while.  So my last binaries are
compiled without bootstrapping.
* I've tried to reproduce your recipe in the OP, but I can't.  I
evaluate the defadvice and then do `M-x ad-activate <RET> foo <RET>'
but `foo' is not a valid argument there.  If you give me a precise
recipe, I'll try to reproduce the steps and see if the Lisp debugger
fires up.


-- 
Dani Moncayo

Message #23 received at 13085 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Dani Moncayo'" <dmoncayo <at> gmail.com>
Cc: 13085 <at> debbugs.gnu.org, 'Stefan Monnier' <monnier <at> iro.umontreal.ca>
Subject: RE: bug#13085: 24.3.50;
	(invalid-function internal--called-interactively-p--get-frame)
Date: Fri, 7 Dec 2012 10:55:52 -0800

> Probably, I'll upload a new build on Monday.

Thanks.

> FWIW:
> * I've not bootstrapped Emacs for a while.  So my last binaries are
> compiled without bootstrapping.
> * I've tried to reproduce your recipe in the OP, but I can't.  I
> evaluate the defadvice and then do `M-x ad-activate <RET> foo <RET>'
> but `foo' is not a valid argument there.  If you give me a precise
> recipe, I'll try to reproduce the steps and see if the Lisp debugger
> fires up.

Sorry, I don't have a recipe.  I have no idea what's going on.  Perhaps Stefan
has an idea.  Note that someone else reported the same bug (as #13097).

FWIW, I've also had other problems with that last build - e.g., bugs #13113,
#13114, and #13116.  I've gone back to using the build from 11/19, which is the
last one that doesn't seem to have many problems.

Thx - Drew

Message #26 received at 13085 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Dani Moncayo'" <dmoncayo <at> gmail.com>
Cc: 13085 <at> debbugs.gnu.org, nyc4bos <at> aol.com
Subject: RE: bug#13085: 24.3.50;
	(invalid-function internal--called-interactively-p--get-frame)
Date: Fri, 7 Dec 2012 12:51:07 -0800

> Sorry, I don't have a recipe.  I have no idea what's going 
> on.  Perhaps Stefan has an idea.  Note that someone else
> reported the same bug (as #13097).

I can consistently get it to happen by, after loading my setup (which uses
byte-compiled files), loading one of the source files *.el whose .elc was
loaded.

But attempts to bifurcate that file to see what might be going on have failed.
It seems unpredictable which portions of the file can trigger the problem.

Without finding some specific bit of code that would also repro the pb outside
my setup, I'm afraid we'll just have to wait for the next build and see if
perhaps that fixes the problem.

Message #29 received at submit <at> debbugs.gnu.org (full text, mbox):

From: nyc4bos <at> aol.com
To: bug-gnu-emacs <at> gnu.org
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>,
	Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#13085: 24.3.50;
	(invalid-function internal--called-interactively-p--get-frame)
Date: Fri, 07 Dec 2012 15:31:13 -0500

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> OK, but my nadvice.elc is the one delivered with the Emacs binary
>> I downloaded.  I did not compile nadvice.el myself.
>
> I kind of guessed it, but that just pushes the question elsewhere.
> IOW, we need to hear from those who built this binary.

FWIW, I got a similiar error message but I wasn't using "advice",
just ^X^W (`write-file') -- bug#13097.

Thanks.

Message #32 received at 13085 <at> debbugs.gnu.org (full text, mbox):

From: Dani Moncayo <dmoncayo <at> gmail.com>
To: nyc4bos <at> aol.com
Cc: 13085 <at> debbugs.gnu.org
Subject: Re: bug#13085: 24.3.50;
	(invalid-function internal--called-interactively-p--get-frame)
Date: Fri, 7 Dec 2012 22:29:21 +0100

>>> OK, but my nadvice.elc is the one delivered with the Emacs binary
>>> I downloaded.  I did not compile nadvice.el myself.
>>
>> I kind of guessed it, but that just pushes the question elsewhere.
>> IOW, we need to hear from those who built this binary.
>
> FWIW, I got a similiar error message but I wasn't using "advice",
> just ^X^W (`write-file') -- bug#13097.

I've made and uploaded a new build of the trunk, this time with a full
bootstrap.

I hope this one works well.

-- 
Dani Moncayo

Message #35 received at 13085 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Dani Moncayo <dmoncayo <at> gmail.com>
Cc: 13085 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#13085: 24.3.50;
	(invalid-function internal--called-interactively-p--get-frame)
Date: Fri, 07 Dec 2012 16:36:00 -0500

> Probably, I'll upload a new build on Monday.

Then just "rm lisp/emacs-lisp/nadvice.elc" before rebuilding (that will
save you the trouble of a whole bootstrap).
Maybe "rm lisp/emacs-lisp/edebug.elc" is also needed.  Basically check

  find -name '*.elc' | xargs grep internal--called-interactively-p--get-frame"

and make sure this only appears in subr.elc.


        Stefan

Message #38 received at 13085 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 13085 <at> debbugs.gnu.org, dmoncayo <at> gmail.com
Subject: Re: bug#13085: 24.3.50;
	(invalid-function internal--called-interactively-p--get-frame)
Date: Fri, 07 Dec 2012 23:42:00 +0200

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Date: Fri, 07 Dec 2012 16:36:00 -0500
> Cc: 13085 <at> debbugs.gnu.org
> 
>   find -name '*.elc' | xargs grep internal--called-interactively-p--get-frame"

On Windows, it is easier to do

  fgrep -R internal--called-interactively-p--get-frame . --include="*.elc"

Message #41 received at 13085 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Dani Moncayo'" <dmoncayo <at> gmail.com>, <nyc4bos <at> aol.com>
Cc: 13085 <at> debbugs.gnu.org
Subject: RE: bug#13085: 24.3.50;
	(invalid-function internal--called-interactively-p--get-frame)
Date: Fri, 7 Dec 2012 14:19:58 -0800

> I've made and uploaded a new build of the trunk, this time with a full
> bootstrap.
> 
> I hope this one works well.

Thx.  I tried it and so far so good.  At least when I run the recipe that
faithfully raises the problem in the previous build there is no problem with the
latest one.  Thx for the quick update.

Message #46 received at 13085 <at> debbugs.gnu.org (full text, mbox):

From: nyc4bos <at> aol.com
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 13085 <at> debbugs.gnu.org, 'Dani Moncayo' <dmoncayo <at> gmail.com>
Subject: Re: bug#13085: 24.3.50;
	(invalid-function internal--called-interactively-p--get-frame)
Date: Mon, 10 Dec 2012 17:53:45 -0500

"Drew Adams" <drew.adams <at> oracle.com> writes:

>> I've made and uploaded a new build of the trunk, this time with a full
>> bootstrap.
>> 
>> I hope this one works well.
>
> Thx.  I tried it and so far so good.  At least when I run the recipe that
> faithfully raises the problem in the previous build there is no problem with the
> latest one.  Thx for the quick update.

It is working so far for me as well.

Thanks for you efforts and quick update Dani.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.