GNU bug report logs - #12979
24.2; [PATCH] fix indentation for closing tag in sgml-tag

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo <sdl.web <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#12979: closed (24.2; [PATCH] fix indentation for closing tag
 in sgml-tag)
Date: Sun, 25 Nov 2012 16:14:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 26 Nov 2012 00:11:18 +0800
with message-id <m17gp9br2x.fsf <at> gmail.com>
and subject line Re: bug#12979: 24.2; [PATCH] fix indentation for closing tag in sgml-tag
has caused the debbugs.gnu.org bug report #12979,
regarding 24.2; [PATCH] fix indentation for closing tag in sgml-tag
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
12979: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12979
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.2; [PATCH] fix indentation for closing tag in sgml-tag
Date: Sat, 24 Nov 2012 17:19:56 +0800

[Message part 3 (text/plain, inline)]

Try inserting tag, such as `form' in html mode using M-x sgml-tag and
you will see the closing tag incorrectly indented as shown here:

[sgml-tag-bug.png (image/png, attachment)]

[Message part 5 (text/plain, inline)]

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index b417df62..eb549017 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,7 @@
+2012-11-24  Leo Liu  <sdl.web <at> gmail.com>
+
+	* textmodes/sgml-mode.el (sgml-tag): Fix indentation for closing tag.
+
 2012-10-05  Glenn Morris  <rgm <at> gnu.org>
 
 	* net/newst-treeview.el (newsticker-group-move-feed): Doc fix.
diff --git a/lisp/textmodes/sgml-mode.el b/lisp/textmodes/sgml-mode.el
index 09f6b6b7..d3b779d2 100644
--- a/lisp/textmodes/sgml-mode.el
+++ b/lisp/textmodes/sgml-mode.el
@@ -672,13 +672,13 @@ (define-skeleton sgml-tag
       (if (eq v2 t) (setq v2 nil))
       ;; We use `identity' to prevent skeleton from passing
       ;; `str' through `skeleton-transformation-function' a second time.
-      '(("") v2 _ v2 "</" (identity ',str) ?>))
+      '(("") v2 _ v2 "</" (identity ',str) ?> >))
      ((eq (car v2) t)
       (cons '("") (cdr v2)))
      (t
       (append '(("") (car v2))
 	      (cdr v2)
-	      '(resume: (car v2) _ "</" (identity ',str) ?>))))))
+	      '(resume: (car v2) _ "</" (identity ',str) ?> >))))))
 
 (autoload 'skeleton-read "skeleton")
 

[Message part 6 (message/rfc822, inline)]

From: Leo <sdl.web <at> gmail.com>
To: 12979-done <at> debbugs.gnu.org
Subject: Re: bug#12979: 24.2;
	[PATCH] fix indentation for closing tag in sgml-tag
Date: Mon, 26 Nov 2012 00:11:18 +0800

Fixed in trunk.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.