GNU bug report logs - #12979
24.2; [PATCH] fix indentation for closing tag in sgml-tag

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12979 in the body.
You can then email your comments to 12979 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.2; [PATCH] fix indentation for closing tag in sgml-tag
Date: Sat, 24 Nov 2012 17:19:56 +0800

[Message part 1 (text/plain, inline)]

Try inserting tag, such as `form' in html mode using M-x sgml-tag and
you will see the closing tag incorrectly indented as shown here:

[sgml-tag-bug.png (image/png, attachment)]

[Message part 3 (text/plain, inline)]

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index b417df62..eb549017 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,7 @@
+2012-11-24  Leo Liu  <sdl.web <at> gmail.com>
+
+	* textmodes/sgml-mode.el (sgml-tag): Fix indentation for closing tag.
+
 2012-10-05  Glenn Morris  <rgm <at> gnu.org>
 
 	* net/newst-treeview.el (newsticker-group-move-feed): Doc fix.
diff --git a/lisp/textmodes/sgml-mode.el b/lisp/textmodes/sgml-mode.el
index 09f6b6b7..d3b779d2 100644
--- a/lisp/textmodes/sgml-mode.el
+++ b/lisp/textmodes/sgml-mode.el
@@ -672,13 +672,13 @@ (define-skeleton sgml-tag
       (if (eq v2 t) (setq v2 nil))
       ;; We use `identity' to prevent skeleton from passing
       ;; `str' through `skeleton-transformation-function' a second time.
-      '(("") v2 _ v2 "</" (identity ',str) ?>))
+      '(("") v2 _ v2 "</" (identity ',str) ?> >))
      ((eq (car v2) t)
       (cons '("") (cdr v2)))
      (t
       (append '(("") (car v2))
 	      (cdr v2)
-	      '(resume: (car v2) _ "</" (identity ',str) ?>))))))
+	      '(resume: (car v2) _ "</" (identity ',str) ?> >))))))
 
 (autoload 'skeleton-read "skeleton")
 

Message #8 received at 12979 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo <sdl.web <at> gmail.com>
Cc: 12979 <at> debbugs.gnu.org
Subject: Re: bug#12979: 24.2;
	[PATCH] fix indentation for closing tag in sgml-tag
Date: Sat, 24 Nov 2012 10:24:46 -0500

> Try inserting tag, such as `form' in html mode using M-x sgml-tag and
> you will see the closing tag incorrectly indented as shown here:

Looks good, feel free to install it on the trunk, thanks,


        Stefan

Message #13 received at 12979-done <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: 12979-done <at> debbugs.gnu.org
Subject: Re: bug#12979: 24.2;
	[PATCH] fix indentation for closing tag in sgml-tag
Date: Mon, 26 Nov 2012 00:11:18 +0800

Fixed in trunk.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.