GNU bug report logs - #12966
cut: Problems with overlapping, open-ended ranges

Previous Next

Full log

Message #31 received at 12966-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Pádraig Brady <P <at> draigBrady.com>
Cc: 12966-done <at> debbugs.gnu.org, Marcel Böhme <hawkie <at> web.de>
Subject: Re: bug#12966: cut: Problems with overlapping, open-ended ranges
Date: Sun, 25 Nov 2012 16:50:35 +0100

Pádraig Brady wrote:
> On 11/24/2012 07:40 PM, Jim Meyering wrote:
>
>> diff --git a/src/cut.c b/src/cut.c
>> index b464840..4219d24 100644
>> --- a/src/cut.c
>> +++ b/src/cut.c
>> @@ -514,17 +514,18 @@ set_fields (const char *fieldstr)
>>     /* Set the array entries corresponding to integers in the ranges of RP.  */
>>     for (i = 0; i < n_rp; i++)
>>       {
>> -      size_t j;
>> -      size_t rsi_candidate;
>> +      /* Ignore any range that is subsumed by the to-EOL range.  */
>> +      if (eol_range_start && eol_range_start <= rp[i].lo)
>> +        continue;
>
> looks good.

Pushed (and marked "done").
Thanks for the review.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.