GNU bug report logs - #12966
cut: Problems with overlapping, open-ended ranges

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Meyering <jim <at> meyering.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#12966: closed (cut: Problems with overlapping, open-ended ranges)
Date: Sun, 25 Nov 2012 15:53:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 25 Nov 2012 16:50:35 +0100
with message-id <87624t4r78.fsf <at> rho.meyering.net>
and subject line Re: bug#12966: cut: Problems with overlapping, open-ended ranges
has caused the debbugs.gnu.org bug report #12966,
regarding cut: Problems with overlapping, open-ended ranges
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
12966: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12966
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Marcel Böhme" <hawkie <at> web.de>
To: bug-coreutils <at> gnu.org
Subject: cut: Problems with overlapping, open-ended ranges
Date: Fri, 23 Nov 2012 09:11:46 +0100 (CET)

[Message part 3 (text/html, inline)]

[Message part 4 (message/rfc822, inline)]

From: Jim Meyering <jim <at> meyering.net>
To: Pádraig Brady <P <at> draigBrady.com>
Cc: 12966-done <at> debbugs.gnu.org, Marcel Böhme <hawkie <at> web.de>
Subject: Re: bug#12966: cut: Problems with overlapping, open-ended ranges
Date: Sun, 25 Nov 2012 16:50:35 +0100

Pádraig Brady wrote:
> On 11/24/2012 07:40 PM, Jim Meyering wrote:
>
>> diff --git a/src/cut.c b/src/cut.c
>> index b464840..4219d24 100644
>> --- a/src/cut.c
>> +++ b/src/cut.c
>> @@ -514,17 +514,18 @@ set_fields (const char *fieldstr)
>>     /* Set the array entries corresponding to integers in the ranges of RP.  */
>>     for (i = 0; i < n_rp; i++)
>>       {
>> -      size_t j;
>> -      size_t rsi_candidate;
>> +      /* Ignore any range that is subsumed by the to-EOL range.  */
>> +      if (eol_range_start && eol_range_start <= rp[i].lo)
>> +        continue;
>
> looks good.

Pushed (and marked "done").
Thanks for the review.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.