GNU bug report logs - #12913
[patch] an overlooked string in 'uptime'

Previous Next

Package: coreutils;

Reported by: Benno Schulenberg <bensberg <at> justemail.net>

Date: Sat, 17 Nov 2012 10:59:01 UTC

Severity: normal

Tags: patch

Done: Pádraig Brady <P <at> draigBrady.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Pádraig Brady <P <at> draigBrady.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#12913: closed ([patch] an overlooked string in 'uptime')
Date: Sat, 12 Jan 2013 13:38:09 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sat, 12 Jan 2013 13:37:13 +0000
with message-id <50F16709.3010502 <at> draigBrady.com>
and subject line Re: bug#12913: [patch] an overlooked string in 'uptime'
has caused the debbugs.gnu.org bug report #12913,
regarding [patch] an overlooked string in 'uptime'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
12913: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12913
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Benno Schulenberg <bensberg <at> justemail.net>
To: Coreutils <bug-coreutils <at> gnu.org>
Subject: [patch] an overlooked string in 'uptime'
Date: Sat, 17 Nov 2012 11:56:57 +0100
[Message part 3 (text/plain, inline)]
Hi,

Well, tiny patch says everything.

Benno

-- 
http://www.fastmail.fm - One of many happy users:
  http://www.fastmail.fm/help/overview_quotes.html

[0001-uptime-gettextize-an-overlooked-string-and-normalize.patch (text/x-patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Pádraig Brady <P <at> draigBrady.com>
To: Benno Schulenberg <bensberg <at> justemail.net>
Cc: 12913-done <at> debbugs.gnu.org
Subject: Re: bug#12913: [patch] an overlooked string in 'uptime'
Date: Sat, 12 Jan 2013 13:37:13 +0000
On 11/17/2012 10:56 AM, Benno Schulenberg wrote:
>  From 855f5c860acb350125476765cf064f6ccc4d2aaa Mon Sep 17 00:00:00 2001
> From: Benno Schulenberg<bensberg <at> justemail.net>
> Date: Sat, 17 Nov 2012 11:49:21 +0100
> Subject: [PATCH] uptime: gettextize an overlooked string, and normalize another
>
> * src/uptime.c: Add calls to gettext() and select_plural().
> ---
>   src/uptime.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/uptime.c b/src/uptime.c
> index f8c7cfa..1bef1cb 100644
> --- a/src/uptime.c
> +++ b/src/uptime.c
> @@ -146,9 +146,9 @@ print_uptime (size_t n, const STRUCT_UTMP *this)
>                             select_plural (updays)),
>                   updays, uphours, upmins);
>         else
> -        printf ("up  %2d:%02d,  ", uphours, upmins);
> +        printf (_("up  %2d:%02d,  "), uphours, upmins);
>       }
> -  printf (ngettext ("%lu user", "%lu users", entries),
> +  printf (ngettext ("%lu user", "%lu users", select_plural (entries)),
>             (unsigned long int) entries);
>
>     loads = getloadavg (avg, 3);
> -- 1.7.0.4

pushed

thanks,
Pádraig.



This bug report was last modified 12 years and 134 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.