GNU bug report logs - #12913
[patch] an overlooked string in 'uptime'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12913 in the body.
You can then email your comments to 12913 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Benno Schulenberg <bensberg <at> justemail.net>
To: Coreutils <bug-coreutils <at> gnu.org>
Subject: [patch] an overlooked string in 'uptime'
Date: Sat, 17 Nov 2012 11:56:57 +0100

[Message part 1 (text/plain, inline)]

Hi,

Well, tiny patch says everything.

Benno

-- 
http://www.fastmail.fm - One of many happy users:
  http://www.fastmail.fm/help/overview_quotes.html

[0001-uptime-gettextize-an-overlooked-string-and-normalize.patch (text/x-patch, attachment)]

Message #8 received at 12913 <at> debbugs.gnu.org (full text, mbox):

From: Benno Schulenberg <bensberg <at> justemail.net>
To: 12913 <at> debbugs.gnu.org
Subject: gettextizing an overlooked string in 'uptime'
Date: Sat, 12 Jan 2013 12:55:53 +0100

Ping?

-- 
http://www.fastmail.fm - The professional email service

Message #13 received at 12913-done <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Benno Schulenberg <bensberg <at> justemail.net>
Cc: 12913-done <at> debbugs.gnu.org
Subject: Re: bug#12913: [patch] an overlooked string in 'uptime'
Date: Sat, 12 Jan 2013 13:37:13 +0000

On 11/17/2012 10:56 AM, Benno Schulenberg wrote:
>  From 855f5c860acb350125476765cf064f6ccc4d2aaa Mon Sep 17 00:00:00 2001
> From: Benno Schulenberg<bensberg <at> justemail.net>
> Date: Sat, 17 Nov 2012 11:49:21 +0100
> Subject: [PATCH] uptime: gettextize an overlooked string, and normalize another
>
> * src/uptime.c: Add calls to gettext() and select_plural().
> ---
>   src/uptime.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/uptime.c b/src/uptime.c
> index f8c7cfa..1bef1cb 100644
> --- a/src/uptime.c
> +++ b/src/uptime.c
> @@ -146,9 +146,9 @@ print_uptime (size_t n, const STRUCT_UTMP *this)
>                             select_plural (updays)),
>                   updays, uphours, upmins);
>         else
> -        printf ("up  %2d:%02d,  ", uphours, upmins);
> +        printf (_("up  %2d:%02d,  "), uphours, upmins);
>       }
> -  printf (ngettext ("%lu user", "%lu users", entries),
> +  printf (ngettext ("%lu user", "%lu users", select_plural (entries)),
>             (unsigned long int) entries);
>
>     loads = getloadavg (avg, 3);
> -- 1.7.0.4

pushed

thanks,
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.