GNU bug report logs - #12912
24.3.50; doc string for `read-face-name'

Previous Next

Package: emacs;

Reported by: "Drew Adams" <drew.adams <at> oracle.com>

Date: Sat, 17 Nov 2012 00:39:02 UTC

Severity: minor

Found in version 24.3.50

Done: Chong Yidong <cyd <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Chong Yidong <cyd <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#12912: closed (24.3.50; doc string for `read-face-name')
Date: Wed, 09 Jan 2013 09:48:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 09 Jan 2013 17:46:57 +0800
with message-id <87bocy4rji.fsf <at> gnu.org>
and subject line Re: bug#12912: 24.3.50; doc string for `read-face-name'
has caused the debbugs.gnu.org bug report #12912,
regarding 24.3.50; doc string for `read-face-name'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
12912: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12912
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.3.50; doc string for `read-face-name'
Date: Fri, 16 Nov 2012 16:37:34 -0800
This doc seems to be incomplete and unclear wrt DEFAULT.
 
It speaks of a case where DEFAULT is not a string.  It does not say what
else it must/can be (besides nil).  Can it be a symbol - e.g., a face
symbol?  Can it be a list of strings, i.e., multiple defaults?  A list
of faces (symbols)?
 
What's more, there is nothing in the doc string that indicates that the
face name(s) is/are read using `completing-read-multiple'.  Not that
that implementation detail need be mentioned explicitly, but its
_behavior_, i.e., what the behavior of `read-face-name' is, should be
described.
 
In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
 of 2012-11-05 on MS-W7-DANI
Bzr revision: 110809 lekktu <at> gmail.com-20121105172930-a5gn0bwi4lndchhw
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
 -I../../libs/libXpm-3.5.10/include -I../../libs/libXpm-3.5.10/src
 -I../../libs/libpng-1.2.37-lib/include -I../../libs/zlib-1.2.5
 -I../../libs/giflib-4.1.4-1-lib/include
 -I../../libs/jpeg-6b-4-lib/include
 -I../../libs/tiff-3.8.2-1-lib/include
 -I../../libs/libxml2-2.7.8-w32-bin/include/libxml2
 -I../../libs/gnutls-3.0.9-w32-bin/include
 -I../../libs/libiconv-1.9.2-1-lib/include'
 



[Message part 3 (message/rfc822, inline)]
From: Chong Yidong <cyd <at> gnu.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 12912-done <at> debbugs.gnu.org
Subject: Re: bug#12912: 24.3.50; doc string for `read-face-name'
Date: Wed, 09 Jan 2013 17:46:57 +0800
"Drew Adams" <drew.adams <at> oracle.com> writes:

> This doc seems to be incomplete and unclear wrt DEFAULT.
>  
> It speaks of a case where DEFAULT is not a string.  It does not say what
> else it must/can be (besides nil).  Can it be a symbol - e.g., a face
> symbol?  Can it be a list of strings, i.e., multiple defaults?  A list
> of faces (symbols)?
>  
> What's more, there is nothing in the doc string that indicates that the
> face name(s) is/are read using `completing-read-multiple'.  Not that
> that implementation detail need be mentioned explicitly, but its
> _behavior_, i.e., what the behavior of `read-face-name' is, should be
> described.

Should be fixed now, thanks.


This bug report was last modified 12 years and 138 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.