GNU bug report logs - #1277
23.0.60; vc revert dialog may need new lines

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 1277 in the body.
You can then email your comments to 1277 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: robert marshall <robert.marshall <at> tnei.co.uk>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.60; vc revert dialog may need new lines
Date: Thu, 30 Oct 2008 14:32:26 +0000

If you go into a vc-dir directory and mark a number of edited files
and then off the menu select 'Revert to base version', the dialog which
asks whether you want to discard changes lists all the files without
any new lines between the file names!

The yes/no buttons may then be an awful long way across the screen!

I've managed to cause emacs to hang with one revert request - maybe
because the dialog was just too wide?

Thanks


In GNU Emacs 23.0.60.8 (i686-pc-linux-gnu, GTK+ Version 2.12.9)
 of 2008-10-28 on rajm-laptop
Windowing system distributor `The X.Org Foundation', version 11.0.10400090
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: VC dir

Minor modes in effect:
  diff-auto-refine-mode: t
  recentf-mode: t
  show-paren-mode: t
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Message #10 received at 1277-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: robert marshall <robert.marshall <at> tnei.co.uk>
Cc: 1277-done <at> debbugs.gnu.org
Subject: Re: 23.0.60; vc revert dialog may need new lines
Date: Thu, 30 Oct 2008 15:21:39 -0400

I've checked in a fix, thanks.

Message #15 received at 1277 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 1277 <at> debbugs.gnu.org
Subject: Re: 23.0.60; select_window_norecord chokes on dead window
Date: Thu, 30 Oct 2008 19:16:25 -0400

> (progn
>    (setq debug-on-error t)
>    (set-frame-height (selected-frame) 10)
>    (split-window)
>    (temp-buffer-resize-mode)
>    (setq temp-buffer-max-height 20))
>
> and do
>
>    C-h v temp-buffer-max-height
>
> Gets me
>
> Debugger entered--Lisp error: (wrong-type-argument window-live-p #<window 3>)
>    describe-variable(temp-buffer-max-height)
>    call-interactively(describe-variable nil nil)
>
> FWIW, the reason is that `fit-window-to-buffer' deletes prev_window
> temp_output_buffer_show eventually wants to resurrect after running
> `temp-buffer-show-hook'.  The attached patch fixes this for me.

Looks OK to me.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.