GNU bug report logs - #1276
23.0.60; select_window_norecord chokes on dead window

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 1276 in the body.
You can then email your comments to 1276 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: emacs-pretest-bug <emacs-pretest-bug <at> gnu.org>
Subject: 23.0.60; select_window_norecord chokes on dead window
Date: Thu, 30 Oct 2008 12:39:58 +0100

[Message part 1 (text/plain, inline)]

To reproduce with emacs -Q evaluate the following form

(progn
   (setq debug-on-error t)
   (set-frame-height (selected-frame) 10)
   (split-window)
   (temp-buffer-resize-mode)
   (setq temp-buffer-max-height 20))

and do

   C-h v temp-buffer-max-height

Gets me

Debugger entered--Lisp error: (wrong-type-argument window-live-p #<window 3>)
   describe-variable(temp-buffer-max-height)
   call-interactively(describe-variable nil nil)


FWIW, the reason is that `fit-window-to-buffer' deletes prev_window
temp_output_buffer_show eventually wants to resurrect after running
`temp-buffer-show-hook'.  The attached patch fixes this for me.

martin, who thinks that `fit-window-to-buffer' shouldn't delete windows ...

[select_window_norecord.diff (text/plain, inline)]

*** window.c.~1.631.~	2008-10-29 10:29:14.718750000 +0100
--- window.c	2008-10-30 11:08:50.406250000 +0100
***************
*** 3643,3649 ****
  select_window_norecord (window)
       Lisp_Object window;
  {
!   return Fselect_window (window, Qt);
  }
  
  Lisp_Object
--- 3643,3650 ----
  select_window_norecord (window)
       Lisp_Object window;
  {
!   return WINDOW_LIVE_P (window)
!     ? Fselect_window (window, Qt) : selected_window;
  }
  
  Lisp_Object

Message #10 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 1276 <at> debbugs.gnu.org,
        emacs-pretest-bug <emacs-pretest-bug <at> gnu.org>
Subject: Re: bug#1276: 23.0.60; select_window_norecord chokes on dead window
Date: Thu, 30 Oct 2008 14:41:01 -0400

> martin, who thinks that `fit-window-to-buffer' shouldn't delete windows ...

Yes, it looks like a bug.


        Stefan

Message #20 received at 1276-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: 1276-done <at> debbugs.gnu.org
Subject: Re: bug#1276: 23.0.60; select_window_norecord chokes on dead window
Date: Fri, 31 Oct 2008 15:07:41 +0100

Fixed as

2008-10-31  Martin Rudalics  <rudalics <at> gmx.at>

	* window.c [...]
	(select_window_norecord): Fix return value.  (Bug#1276)

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.