GNU bug report logs - #12728
v8.20 is missing LIBICONV for factor tool

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Pádraig Brady <P <at> draigBrady.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#12728: closed (v8.20 is missing LIBICONV for factor tool)
Date: Thu, 25 Oct 2012 09:57:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 25 Oct 2012 10:54:33 +0100
with message-id <50890C59.9040308 <at> draigBrady.com>
and subject line Re: bug#12728: v8.20 is missing LIBICONV for factor tool
has caused the debbugs.gnu.org bug report #12728,
regarding v8.20 is missing LIBICONV for factor tool
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
12728: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12728
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Christian Jullien" <eligis <at> orange.fr>
To: <bug-coreutils <at> gnu.org>
Subject: v8.20 is missing LIBICONV for factor tool
Date: Thu, 25 Oct 2012 06:30:57 +0200

[Message part 3 (text/plain, inline)]

Hi maintainers,

 

Trying to compile new 8.20 version on my Solaris 10 sparc machine using gcc
4.7.2, I got an error on factor link:

 

CCLD   src/factor

lib/libcoreutils.a(striconv.o): In function `mem_cd_iconv':

/export/home/jullien/coreutils-8.20/lib/striconv.c:55: undefined reference
to `libiconv'

/export/home/jullien/coreutils-8.20/lib/striconv.c:72: undefined reference
to `libiconv'

 

I easily fixed this issue adding $(LIBICONV) on Makefile.in (Line 3117):

 

< src_factor_LDADD = $(LDADD) $(LIB_GMP)

> src_factor_LDADD = $(LDADD) $(LIB_GMP) $(LIBICONV)

 

This is the only issue I had.

 

Thanks to include this fix for the next release.

 

Christian

[Message part 4 (text/html, inline)]

[Message part 5 (message/rfc822, inline)]

From: Pádraig Brady <P <at> draigBrady.com>
To: Christian Jullien <eligis <at> orange.fr>
Cc: 12728-done <at> debbugs.gnu.org
Subject: Re: bug#12728: v8.20 is missing LIBICONV for factor tool
Date: Thu, 25 Oct 2012 10:54:33 +0100

On 10/25/2012 05:30 AM, Christian Jullien wrote:
> Hi maintainers,
>
> Trying to compile new 8.20 version on my Solaris 10 sparc machine using gcc
> 4.7.2, I got an error on factor link:
>
> CCLD   src/factor
>
> lib/libcoreutils.a(striconv.o): In function `mem_cd_iconv':
>
> /export/home/jullien/coreutils-8.20/lib/striconv.c:55: undefined reference
> to `libiconv'

Right you are.
This is required in the new factor because of:

  proper_name_utf8 ("Torbjorn Granlund", "Torbj\303\266rn Granlund"),   \
  proper_name_utf8 ("Niels Moller", "Niels M\303\266ller")

I didn't pick up the issue on my gcc 3.4.3, solaris 10, sparc
test system because of:

  $ grep ICONV lib/config.h
  /* #undef HAVE_ICONV */
  #define HAVE_ICONV_H 1
  #define ICONV_CONST const
  #define ICONV_FLAVOR ICONV_FLAVOR_SOLARIS

To fix this up I'll add in:

diff --git a/src/local.mk b/src/local.mk
index 6a01ef1..f40f681 100644
--- a/src/local.mk
+++ b/src/local.mk
@@ -277,6 +277,7 @@ src_cat_LDADD += $(LIBICONV)
 src_cp_LDADD += $(LIBICONV)
 src_df_LDADD += $(LIBICONV)
 src_du_LDADD += $(LIBICONV)
+src_factor_LDADD += $(LIBICONV)
 src_getlimits_LDADD += $(LIBICONV)
 src_printf_LDADD += $(LIBICONV)
 src_ptx_LDADD += $(LIBICONV)

thanks!
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.