GNU bug report logs -
#12728
v8.20 is missing LIBICONV for factor tool
Previous Next
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12728 in the body.
You can then email your comments to 12728 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-coreutils <at> gnu.org:
bug#12728; Package
coreutils.
(Thu, 25 Oct 2012 04:54:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
"Christian Jullien" <eligis <at> orange.fr>:
New bug report received and forwarded. Copy sent to
bug-coreutils <at> gnu.org.
(Thu, 25 Oct 2012 04:54:01 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hi maintainers,
Trying to compile new 8.20 version on my Solaris 10 sparc machine using gcc
4.7.2, I got an error on factor link:
CCLD src/factor
lib/libcoreutils.a(striconv.o): In function `mem_cd_iconv':
/export/home/jullien/coreutils-8.20/lib/striconv.c:55: undefined reference
to `libiconv'
/export/home/jullien/coreutils-8.20/lib/striconv.c:72: undefined reference
to `libiconv'
I easily fixed this issue adding $(LIBICONV) on Makefile.in (Line 3117):
< src_factor_LDADD = $(LDADD) $(LIB_GMP)
> src_factor_LDADD = $(LDADD) $(LIB_GMP) $(LIBICONV)
This is the only issue I had.
Thanks to include this fix for the next release.
Christian
[Message part 2 (text/html, inline)]
Reply sent
to
Pádraig Brady <P <at> draigBrady.com>:
You have taken responsibility.
(Thu, 25 Oct 2012 09:57:01 GMT)
Full text and
rfc822 format available.
Notification sent
to
"Christian Jullien" <eligis <at> orange.fr>:
bug acknowledged by developer.
(Thu, 25 Oct 2012 09:57:02 GMT)
Full text and
rfc822 format available.
Message #10 received at 12728-done <at> debbugs.gnu.org (full text, mbox):
On 10/25/2012 05:30 AM, Christian Jullien wrote:
> Hi maintainers,
>
> Trying to compile new 8.20 version on my Solaris 10 sparc machine using gcc
> 4.7.2, I got an error on factor link:
>
> CCLD src/factor
>
> lib/libcoreutils.a(striconv.o): In function `mem_cd_iconv':
>
> /export/home/jullien/coreutils-8.20/lib/striconv.c:55: undefined reference
> to `libiconv'
Right you are.
This is required in the new factor because of:
proper_name_utf8 ("Torbjorn Granlund", "Torbj\303\266rn Granlund"), \
proper_name_utf8 ("Niels Moller", "Niels M\303\266ller")
I didn't pick up the issue on my gcc 3.4.3, solaris 10, sparc
test system because of:
$ grep ICONV lib/config.h
/* #undef HAVE_ICONV */
#define HAVE_ICONV_H 1
#define ICONV_CONST const
#define ICONV_FLAVOR ICONV_FLAVOR_SOLARIS
To fix this up I'll add in:
diff --git a/src/local.mk b/src/local.mk
index 6a01ef1..f40f681 100644
--- a/src/local.mk
+++ b/src/local.mk
@@ -277,6 +277,7 @@ src_cat_LDADD += $(LIBICONV)
src_cp_LDADD += $(LIBICONV)
src_df_LDADD += $(LIBICONV)
src_du_LDADD += $(LIBICONV)
+src_factor_LDADD += $(LIBICONV)
src_getlimits_LDADD += $(LIBICONV)
src_printf_LDADD += $(LIBICONV)
src_ptx_LDADD += $(LIBICONV)
thanks!
Pádraig.
Information forwarded
to
bug-coreutils <at> gnu.org:
bug#12728; Package
coreutils.
(Thu, 25 Oct 2012 10:24:01 GMT)
Full text and
rfc822 format available.
Message #13 received at 12728 <at> debbugs.gnu.org (full text, mbox):
Pádraig Brady wrote:
> On 10/25/2012 05:30 AM, Christian Jullien wrote:
>> Hi maintainers,
>>
>> Trying to compile new 8.20 version on my Solaris 10 sparc machine using gcc
>> 4.7.2, I got an error on factor link:
>>
>> CCLD src/factor
>>
>> lib/libcoreutils.a(striconv.o): In function `mem_cd_iconv':
>>
>> /export/home/jullien/coreutils-8.20/lib/striconv.c:55: undefined reference
>> to `libiconv'
>
> Right you are.
> This is required in the new factor because of:
>
> proper_name_utf8 ("Torbjorn Granlund", "Torbj\303\266rn Granlund"), \
> proper_name_utf8 ("Niels Moller", "Niels M\303\266ller")
>
> I didn't pick up the issue on my gcc 3.4.3, solaris 10, sparc
> test system because of:
>
> $ grep ICONV lib/config.h
> /* #undef HAVE_ICONV */
> #define HAVE_ICONV_H 1
> #define ICONV_CONST const
> #define ICONV_FLAVOR ICONV_FLAVOR_SOLARIS
>
> To fix this up I'll add in:
>
> diff --git a/src/local.mk b/src/local.mk
> index 6a01ef1..f40f681 100644
> --- a/src/local.mk
> +++ b/src/local.mk
> @@ -277,6 +277,7 @@ src_cat_LDADD += $(LIBICONV)
> src_cp_LDADD += $(LIBICONV)
> src_df_LDADD += $(LIBICONV)
> src_du_LDADD += $(LIBICONV)
> +src_factor_LDADD += $(LIBICONV)
> src_getlimits_LDADD += $(LIBICONV)
> src_printf_LDADD += $(LIBICONV)
> src_ptx_LDADD += $(LIBICONV)
Thanks for dealing with that.
Along with the fix, please add a syntax-check rule that does something
like this:
cd src; for i in $(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do
grep -E "^src_${i}_LDADD .?= .*\$(LIBICONV)" local.mk > /dev/null \
|| echo FAIL $i
done
Before the fix, it would print this:
FAIL factor
Information forwarded
to
bug-coreutils <at> gnu.org:
bug#12728; Package
coreutils.
(Thu, 25 Oct 2012 12:01:02 GMT)
Full text and
rfc822 format available.
Message #16 received at 12728 <at> debbugs.gnu.org (full text, mbox):
On 10/25/2012 11:21 AM, Jim Meyering wrote:
> Thanks for dealing with that.
> Along with the fix, please add a syntax-check rule that does something
> like this:
>
> cd src; for i in $(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do
> grep -E "^src_${i}_LDADD .?= .*\$(LIBICONV)" local.mk > /dev/null \
> || echo FAIL $i
> done
>
> Before the fix, it would print this:
>
> FAIL factor
Pushed with this:
# Ensure programs with authors with non ASCII names link with LIBICONV
sc_check-I18N-AUTHORS:
@(cd $(srcdir)/src && \
for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do \
grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk > \
/dev/null || { echo FAIL $$i; exit 1; }; \
done)
thanks,
Pádraig.
Information forwarded
to
bug-coreutils <at> gnu.org:
bug#12728; Package
coreutils.
(Thu, 25 Oct 2012 16:39:02 GMT)
Full text and
rfc822 format available.
Message #19 received at 12728 <at> debbugs.gnu.org (full text, mbox):
Pádraig Brady wrote:
> On 10/25/2012 11:21 AM, Jim Meyering wrote:
>> Thanks for dealing with that.
>> Along with the fix, please add a syntax-check rule that does something
>> like this:
>>
>> cd src; for i in $(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do
>> grep -E "^src_${i}_LDADD .?= .*\$(LIBICONV)" local.mk > /dev/null \
>> || echo FAIL $i
>> done
>>
>> Before the fix, it would print this:
>>
>> FAIL factor
>
> Pushed with this:
>
> # Ensure programs with authors with non ASCII names link with LIBICONV
> sc_check-I18N-AUTHORS:
> @(cd $(srcdir)/src && \
> for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do \
> grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk > \
> /dev/null || { echo FAIL $$i; exit 1; }; \
> done)
Thanks!
I wanted to include a little more information in the diagnostic, so...
From 74da4c80470bffe3ccfaead598dad36bf64f1b97 Mon Sep 17 00:00:00 2001
From: Jim Meyering <jim <at> meyering.net>
Date: Thu, 25 Oct 2012 18:35:34 +0200
Subject: [PATCH] maint: tweak sc_check-I18N-AUTHORS
* cfg.mk (sc_check-I18N-AUTHORS): Remove unnecessary subshell;
add a self-explanatory diagnostic.
---
cfg.mk | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/cfg.mk b/cfg.mk
index 40ece55..08f6c3d 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -181,13 +181,15 @@ sc_check-AUTHORS: $(all_programs)
&& diff $(au_actual) $(au_dotdot) \
&& rm -f $(au_actual) $(au_dotdot)
-# Ensure programs with authors with non ASCII names link with LIBICONV
+# Each program with a non-ASCII author name must link with LIBICONV.
sc_check-I18N-AUTHORS:
- @(cd $(srcdir)/src && \
+ @cd $(srcdir)/src && \
for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do \
- grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk > \
- /dev/null || { echo FAIL $$i; exit 1; }; \
- done)
+ grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk \
+ > /dev/null \
+ || { "echo $(ME): link rules for $$i do not include" \
+ '$$(LIBICONV)' 1>&2; exit 1; }; \
+ done
# Look for lines longer than 80 characters, except omit:
# - program-generated long lines in diff headers,
--
1.8.0
Information forwarded
to
bug-coreutils <at> gnu.org:
bug#12728; Package
coreutils.
(Thu, 25 Oct 2012 17:57:02 GMT)
Full text and
rfc822 format available.
Message #22 received at 12728 <at> debbugs.gnu.org (full text, mbox):
On 10/25/2012 05:36 PM, Jim Meyering wrote:
> Thanks!
> I wanted to include a little more information in the diagnostic, so...
looks good. thanks
Information forwarded
to
bug-coreutils <at> gnu.org:
bug#12728; Package
coreutils.
(Thu, 25 Oct 2012 19:34:02 GMT)
Full text and
rfc822 format available.
Message #25 received at 12728 <at> debbugs.gnu.org (full text, mbox):
Pádraig Brady wrote:
> On 10/25/2012 05:36 PM, Jim Meyering wrote:
>> Thanks!
>> I wanted to include a little more information in the diagnostic, so...
>
> looks good. thanks
Thanks for the review. Pushed.
Information forwarded
to
bug-coreutils <at> gnu.org:
bug#12728; Package
coreutils.
(Sun, 04 Nov 2012 01:03:01 GMT)
Full text and
rfc822 format available.
Message #28 received at 12728 <at> debbugs.gnu.org (full text, mbox):
On 10/25/2012 05:36 PM, Jim Meyering wrote:
> Pádraig Brady wrote:
>
>> On 10/25/2012 11:21 AM, Jim Meyering wrote:
>>> Thanks for dealing with that.
>>> Along with the fix, please add a syntax-check rule that does something
>>> like this:
>>>
>>> cd src; for i in $(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do
>>> grep -E "^src_${i}_LDADD .?= .*\$(LIBICONV)" local.mk > /dev/null \
>>> || echo FAIL $i
>>> done
>>>
>>> Before the fix, it would print this:
>>>
>>> FAIL factor
>>
>> Pushed with this:
>>
>> # Ensure programs with authors with non ASCII names link with LIBICONV
>> sc_check-I18N-AUTHORS:
>> @(cd $(srcdir)/src && \
>> for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do \
>> grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk > \
>> /dev/null || { echo FAIL $$i; exit 1; }; \
>> done)
>
> Thanks!
> I wanted to include a little more information in the diagnostic, so...
>
>>From 74da4c80470bffe3ccfaead598dad36bf64f1b97 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <jim <at> meyering.net>
> Date: Thu, 25 Oct 2012 18:35:34 +0200
> Subject: [PATCH] maint: tweak sc_check-I18N-AUTHORS
>
> * cfg.mk (sc_check-I18N-AUTHORS): Remove unnecessary subshell;
> add a self-explanatory diagnostic.
> ---
> cfg.mk | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/cfg.mk b/cfg.mk
> index 40ece55..08f6c3d 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -181,13 +181,15 @@ sc_check-AUTHORS: $(all_programs)
> && diff $(au_actual) $(au_dotdot) \
> && rm -f $(au_actual) $(au_dotdot)
>
> -# Ensure programs with authors with non ASCII names link with LIBICONV
> +# Each program with a non-ASCII author name must link with LIBICONV.
> sc_check-I18N-AUTHORS:
> - @(cd $(srcdir)/src && \
> + @cd $(srcdir)/src && \
> for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do \
> - grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk > \
> - /dev/null || { echo FAIL $$i; exit 1; }; \
> - done)
> + grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk \
> + > /dev/null \
> + || { "echo $(ME): link rules for $$i do not include" \
> + '$$(LIBICONV)' 1>&2; exit 1; }; \
> + done
>
> # Look for lines longer than 80 characters, except omit:
> # - program-generated long lines in diff headers,
The quoting was a bit off there, so I just pushed this.
cheers,
Pádraig.
commit 8096ec664173f243e045be065203e6ad1aa1fa75
Author: Pádraig Brady <P <at> draigBrady.com>
Date: Sun Nov 4 00:55:57 2012 +0000
maint: fix the error message from sc_check-I18N-AUTHORS
* cfk.mk (sc_check-I18N-AUTHORS): Fix the quoting so
you don't get a 'command not found' error.
diff --git a/cfg.mk b/cfg.mk
index 46652b0..53295b4 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -187,7 +187,7 @@ sc_check-I18N-AUTHORS:
for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do \
grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk \
> /dev/null \
- || { "echo $(ME): link rules for $$i do not include" \
+ || { echo "$(ME): link rules for $$i do not include" \
'$$(LIBICONV)' 1>&2; exit 1; }; \
done
Information forwarded
to
bug-coreutils <at> gnu.org:
bug#12728; Package
coreutils.
(Sun, 04 Nov 2012 04:22:02 GMT)
Full text and
rfc822 format available.
Message #31 received at 12728 <at> debbugs.gnu.org (full text, mbox):
Pádraig Brady wrote:
> On 10/25/2012 05:36 PM, Jim Meyering wrote:
>> Pádraig Brady wrote:
>>
>>> On 10/25/2012 11:21 AM, Jim Meyering wrote:
>>>> Thanks for dealing with that.
>>>> Along with the fix, please add a syntax-check rule that does something
>>>> like this:
>>>>
>>>> cd src; for i in $(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do
>>>> grep -E "^src_${i}_LDADD .?= .*\$(LIBICONV)" local.mk > /dev/null \
>>>> || echo FAIL $i
>>>> done
>>>>
>>>> Before the fix, it would print this:
>>>>
>>>> FAIL factor
>>>
>>> Pushed with this:
>>>
>>> # Ensure programs with authors with non ASCII names link with LIBICONV
>>> sc_check-I18N-AUTHORS:
>>> @(cd $(srcdir)/src && \
>>> for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do \
>>> grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk > \
>>> /dev/null || { echo FAIL $$i; exit 1; }; \
>>> done)
>>
>> Thanks!
>> I wanted to include a little more information in the diagnostic, so...
...
>> + || { "echo $(ME): link rules for $$i do not include" \
>> + '$$(LIBICONV)' 1>&2; exit 1; }; \
...
> The quoting was a bit off there, so I just pushed this.
"off", as in just plain wrong ;)
Thanks for cleaning up after me.
...
> Author: Pádraig Brady <P <at> draigBrady.com>
> Date: Sun Nov 4 00:55:57 2012 +0000
>
> maint: fix the error message from sc_check-I18N-AUTHORS
>
> * cfk.mk (sc_check-I18N-AUTHORS): Fix the quoting so
> you don't get a 'command not found' error.
>
> diff --git a/cfg.mk b/cfg.mk
> index 46652b0..53295b4 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -187,7 +187,7 @@ sc_check-I18N-AUTHORS:
> for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do \
> grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk \
> > /dev/null \
> - || { "echo $(ME): link rules for $$i do not include" \
> + || { echo "$(ME): link rules for $$i do not include" \
> '$$(LIBICONV)' 1>&2; exit 1; }; \
> done
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org.
(Sun, 02 Dec 2012 12:24:03 GMT)
Full text and
rfc822 format available.
This bug report was last modified 12 years and 205 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.