GNU bug report logs - #12334
[patches] two tiny textual fixes for 'touch'

Previous Next

Full log

View this message in rfc822 format

From: Jim Meyering <jim <at> meyering.net>
To: Benno Schulenberg <bensberg <at> justemail.net>
Cc: 12334 <at> debbugs.gnu.org
Subject: bug#12334: [patches] two tiny textual fixes for 'touch'
Date: Sun, 02 Sep 2012 13:54:32 +0200

Benno Schulenberg wrote:
> Hi,
>
> Attached two patches slightly improve the help text
> and documentation of 'touch'.
>
> Regards,
>
> Benno
>
> --
> http://www.fastmail.fm - A no graphics, no pop-ups email service
>
>
> From 5df770d0e0b1d64d18a1ca0885f334e98e892f35 Mon Sep 17 00:00:00 2001
> From: Benno Schulenberg <bensberg <at> justemail.net>
> Date: Sat, 18 Aug 2012 12:18:37 +0200
> Subject: [PATCH 1/2] touch: line up long option in help text properly
>
> ---
>  src/touch.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/touch.c b/src/touch.c
> index 5976a34..3d93464 100644
> --- a/src/touch.c
> +++ b/src/touch.c
> @@ -238,7 +238,7 @@ Mandatory arguments to long options are mandatory for short options too.\n\
>        fputs (_("\
>    -r, --reference=FILE   use this file's times instead of current time\n\
>    -t STAMP               use [[CC]YY]MMDDhhmm[.ss] instead of current time\n\
> -  --time=WORD            change the specified time:\n\
> +      --time=WORD        change the specified time:\n\

Thanks.  I've adjusted your log, as below and pushed.

> From 5a55f3554f4cc6293b8defc0ab7b87299ff9d54a Mon Sep 17 00:00:00 2001
> From: Benno Schulenberg <bensberg <at> justemail.net>
> Date: Sat, 18 Aug 2012 12:20:39 +0200
> Subject: [PATCH 2/2] docs: slightly clarify why touch recognizes option -f
>
> ---
>  doc/coreutils.texi |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/doc/coreutils.texi b/doc/coreutils.texi
> index f2620bc..d143a32 100644
> --- a/doc/coreutils.texi
> +++ b/doc/coreutils.texi
> @@ -10468,7 +10468,7 @@ silently ignore any excess precision here.
>  @item -f
>  @opindex -f
>  @cindex BSD @command{touch} compatibility
> -Ignored; for compatibility with BSD versions of @command{touch}.
> +Ignored; recognized for compatibility with BSD versions of @command{touch}.

This seems understandable to me already.
And besides, the same construct appears in at least 3 other places:

    $ git grep -h 'Igno.*for.compatibi' doc
    Ignored; for compatibility with old Unix versions of @command{install}.
    Ignored; for compatibility with BSD versions of @command{touch}.
    Ignored; for compatibility with System V versions of @command{df}.
    Ignored; for compatibility with other versions of @command{who}.


From e7a02cb58840abe7bc6b530a2d0eaec0dea9623c Mon Sep 17 00:00:00 2001
From: Benno Schulenberg <bensberg <at> justemail.net>
Date: Sat, 18 Aug 2012 12:18:37 +0200
Subject: [PATCH] touch: line up long option in --help text

* src/touch.c (usage): Indent --time=... to line up with all of the
other long options.
---
 src/touch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/touch.c b/src/touch.c
index 5976a34..3d93464 100644
--- a/src/touch.c
+++ b/src/touch.c
@@ -238,7 +238,7 @@ Mandatory arguments to long options are mandatory for short options too.\n\
       fputs (_("\
   -r, --reference=FILE   use this file's times instead of current time\n\
   -t STAMP               use [[CC]YY]MMDDhhmm[.ss] instead of current time\n\
-  --time=WORD            change the specified time:\n\
+      --time=WORD        change the specified time:\n\
                            WORD is access, atime, or use: equivalent to -a\n\
                            WORD is modify or mtime: equivalent to -m\n\
 "), stdout);
--
1.7.12.146.g16d26b1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.