GNU bug report logs - #12334
[patches] two tiny textual fixes for 'touch'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12334 in the body.
You can then email your comments to 12334 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Benno Schulenberg <bensberg <at> justemail.net>
To: bug-coreutils <at> gnu.org
Subject: [patches] two tiny textual fixes for 'touch'
Date: Sun, 02 Sep 2012 13:31:54 +0200

[Message part 1 (text/plain, inline)]

Hi,

Attached two patches slightly improve the help text
and documentation of 'touch'.

Regards,

Benno

-- 
http://www.fastmail.fm - A no graphics, no pop-ups email service

[0001-touch-line-up-long-option-in-help-text-properly.patch (text/x-patch, attachment)]

[0002-docs-slightly-clarify-why-touch-recognizes-option-f.patch (text/x-patch, attachment)]

Message #8 received at 12334 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Benno Schulenberg <bensberg <at> justemail.net>
Cc: 12334 <at> debbugs.gnu.org
Subject: Re: bug#12334: [patches] two tiny textual fixes for 'touch'
Date: Sun, 02 Sep 2012 13:54:32 +0200

Benno Schulenberg wrote:
> Hi,
>
> Attached two patches slightly improve the help text
> and documentation of 'touch'.
>
> Regards,
>
> Benno
>
> --
> http://www.fastmail.fm - A no graphics, no pop-ups email service
>
>
> From 5df770d0e0b1d64d18a1ca0885f334e98e892f35 Mon Sep 17 00:00:00 2001
> From: Benno Schulenberg <bensberg <at> justemail.net>
> Date: Sat, 18 Aug 2012 12:18:37 +0200
> Subject: [PATCH 1/2] touch: line up long option in help text properly
>
> ---
>  src/touch.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/touch.c b/src/touch.c
> index 5976a34..3d93464 100644
> --- a/src/touch.c
> +++ b/src/touch.c
> @@ -238,7 +238,7 @@ Mandatory arguments to long options are mandatory for short options too.\n\
>        fputs (_("\
>    -r, --reference=FILE   use this file's times instead of current time\n\
>    -t STAMP               use [[CC]YY]MMDDhhmm[.ss] instead of current time\n\
> -  --time=WORD            change the specified time:\n\
> +      --time=WORD        change the specified time:\n\

Thanks.  I've adjusted your log, as below and pushed.

> From 5a55f3554f4cc6293b8defc0ab7b87299ff9d54a Mon Sep 17 00:00:00 2001
> From: Benno Schulenberg <bensberg <at> justemail.net>
> Date: Sat, 18 Aug 2012 12:20:39 +0200
> Subject: [PATCH 2/2] docs: slightly clarify why touch recognizes option -f
>
> ---
>  doc/coreutils.texi |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/doc/coreutils.texi b/doc/coreutils.texi
> index f2620bc..d143a32 100644
> --- a/doc/coreutils.texi
> +++ b/doc/coreutils.texi
> @@ -10468,7 +10468,7 @@ silently ignore any excess precision here.
>  @item -f
>  @opindex -f
>  @cindex BSD @command{touch} compatibility
> -Ignored; for compatibility with BSD versions of @command{touch}.
> +Ignored; recognized for compatibility with BSD versions of @command{touch}.

This seems understandable to me already.
And besides, the same construct appears in at least 3 other places:

    $ git grep -h 'Igno.*for.compatibi' doc
    Ignored; for compatibility with old Unix versions of @command{install}.
    Ignored; for compatibility with BSD versions of @command{touch}.
    Ignored; for compatibility with System V versions of @command{df}.
    Ignored; for compatibility with other versions of @command{who}.


From e7a02cb58840abe7bc6b530a2d0eaec0dea9623c Mon Sep 17 00:00:00 2001
From: Benno Schulenberg <bensberg <at> justemail.net>
Date: Sat, 18 Aug 2012 12:18:37 +0200
Subject: [PATCH] touch: line up long option in --help text

* src/touch.c (usage): Indent --time=... to line up with all of the
other long options.
---
 src/touch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/touch.c b/src/touch.c
index 5976a34..3d93464 100644
--- a/src/touch.c
+++ b/src/touch.c
@@ -238,7 +238,7 @@ Mandatory arguments to long options are mandatory for short options too.\n\
       fputs (_("\
   -r, --reference=FILE   use this file's times instead of current time\n\
   -t STAMP               use [[CC]YY]MMDDhhmm[.ss] instead of current time\n\
-  --time=WORD            change the specified time:\n\
+      --time=WORD        change the specified time:\n\
                            WORD is access, atime, or use: equivalent to -a\n\
                            WORD is modify or mtime: equivalent to -m\n\
 "), stdout);
--
1.7.12.146.g16d26b1

Message #11 received at 12334 <at> debbugs.gnu.org (full text, mbox):

From: Benno Schulenberg <bensberg <at> justemail.net>
To: 12334 <at> debbugs.gnu.org
Subject: Re: bug#12334: [patches] two tiny textual fixes for 'touch'
Date: Sun, 02 Sep 2012 16:42:45 +0200

On Sun, Sep 2, 2012, at 13:54, Jim Meyering wrote:
> Benno Schulenberg wrote:
> > -Ignored; for compatibility with BSD versions of @command{touch}.
> > +Ignored; recognized for compatibility with BSD versions of @command{touch}.
> 
> This seems understandable to me already.

Yes, with a little thought jump it's understandable; the sentence
simply makes more sense with the "recognized" included.

> And besides, the same construct appears in at least 3 other places: [...]

Then I would suggest to change them all.  Would such patch be accepted?

Benno

-- 
http://www.fastmail.fm - Choose from over 50 domains or use your own

Message #14 received at 12334 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Benno Schulenberg <bensberg <at> justemail.net>
Cc: 12334 <at> debbugs.gnu.org
Subject: Re: bug#12334: [patches] two tiny textual fixes for 'touch'
Date: Sun, 02 Sep 2012 18:10:17 +0200

Benno Schulenberg wrote:
> On Sun, Sep 2, 2012, at 13:54, Jim Meyering wrote:
>> Benno Schulenberg wrote:
>> > -Ignored; for compatibility with BSD versions of @command{touch}.
>> > +Ignored; recognized for compatibility with BSD versions of @command{touch}.
>>
>> This seems understandable to me already.
>
> Yes, with a little thought jump it's understandable; the sentence
> simply makes more sense with the "recognized" included.
>
>> And besides, the same construct appears in at least 3 other places: [...]
>
> Then I would suggest to change them all.  Would such patch be accepted?

Sure, but please s/recognized/accepted/.

Message #17 received at 12334 <at> debbugs.gnu.org (full text, mbox):

From: Benno Schulenberg <bensberg <at> justemail.net>
To: 12334 <at> debbugs.gnu.org
Subject: Re: bug#12334: [patches] two tiny textual fixes for 'touch'
Date: Mon, 03 Sep 2012 17:47:06 +0200

On Sun, Sep 2, 2012, at 18:10, Jim Meyering wrote:
> Sure, but please s/recognized/accepted/.

Then let it be, as for me "accepted" means just about
the opposite of "ignored".  I chose "recognized" because
'touch' reacts to an option it does not know at all with:
"unrecognized option".

$ touch --the bell
touch: unrecognized option '--the'

Benno

-- 
http://www.fastmail.fm - A no graphics, no pop-ups email service

Message #22 received at 12334-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Benno Schulenberg <bensberg <at> justemail.net>
Cc: 12334-done <at> debbugs.gnu.org
Subject: Re: bug#12334: [patches] two tiny textual fixes for 'touch'
Date: Mon, 03 Sep 2012 18:55:18 +0200

Benno Schulenberg wrote:
> On Sun, Sep 2, 2012, at 18:10, Jim Meyering wrote:
>> Sure, but please s/recognized/accepted/.
>
> Then let it be, as for me "accepted" means just about
> the opposite of "ignored".  I chose "recognized" because
> 'touch' reacts to an option it does not know at all with:
> "unrecognized option".
>
> $ touch --the bell
> touch: unrecognized option '--the'

Leaving things as-is is fine with me.
I've marked this ticket as "done".

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.