GNU bug report logs - #12214
rmail-output-read-file-name Error in Summary (with Patch)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: tftorrey <at> tftorrey.com (T.F. Torrey)
Subject: bug#12214: closed (Re: bug#12214: rmail-output-read-file-name
 Error in Summary (with Patch))
Date: Fri, 17 Aug 2012 20:49:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#12214: rmail-output-read-file-name Error in Summary (with Patch)

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 12214 <at> debbugs.gnu.org.

-- 
12214: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12214
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 12214-done <at> debbugs.gnu.org
Subject: Re: bug#12214: rmail-output-read-file-name Error in Summary (with
	Patch)
Date: Fri, 17 Aug 2012 16:39:56 -0400

Version: 24.3

Thanks for the report. I installed a slightly more complicated fix to
the Emacs trunk, currently expected to appear as Emacs 24.3 at some
point.

[Message part 3 (message/rfc822, inline)]

From: tftorrey <at> tftorrey.com (T.F. Torrey)
To: bug-gnu-emacs <at> gnu.org
Subject: rmail-output-read-file-name Error in Summary (with Patch)
Date: Wed, 15 Aug 2012 16:20:03 -0600

Hello developers,

I'm happy to report a bug and a fix.

Description: When in an Rmail summary buffer,
rmail-output-read-file-name looks for matches in the summary buffer
rather than in the rmail buffer, and thus fails to find the proper
match. The patch below corrects this behavior.

ChangeLog entry: make rmail-output-read-file-name use rmail-buffer when
in summary

I was unable to download the most recent Emacs from bazaar, but I was
able to get the source from the Ubuntu archive, and I think it is
current in this regard. Because of this, I also had to make a slightly
different diff, but I think it will work. It's only a two-line change
anyway.

Diff:

diff -c -L rmailout.el -L \#\<buffer\ rmailout.el\> rmailout.el /tmp/buffer-content-19356i1B
*** rmailout.el
--- #<buffer rmailout.el>
***************
*** 59,64 ****
--- 59,65 ----
  (defun rmail-output-read-file-name ()
    "Read the file name to use for `rmail-output'.
  Set `rmail-default-file' to this name as well as returning it."
+   (with-current-buffer rmail-buffer
    (let ((default-file
  	  (let (answer tail)
  	    (setq tail rmail-output-file-alist)
***************
*** 87,92 ****
--- 88,94 ----
  	      (expand-file-name
  	       (or read-file (file-name-nondirectory default-file))
  	       (file-name-directory default-file)))))))
+ )
  
  (defun rmail-delete-unwanted-fields (preserve)
    "Delete all headers matching `rmail-fields-not-to-output'.

Diff finished.  Wed Aug 15 15:35:47 2012

All the best,
Terry
-- 
T.F. Torrey

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.