GNU bug report logs - #12214
rmail-output-read-file-name Error in Summary (with Patch)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12214 in the body.
You can then email your comments to 12214 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: tftorrey <at> tftorrey.com (T.F. Torrey)
To: bug-gnu-emacs <at> gnu.org
Subject: rmail-output-read-file-name Error in Summary (with Patch)
Date: Wed, 15 Aug 2012 16:20:03 -0600

Hello developers,

I'm happy to report a bug and a fix.

Description: When in an Rmail summary buffer,
rmail-output-read-file-name looks for matches in the summary buffer
rather than in the rmail buffer, and thus fails to find the proper
match. The patch below corrects this behavior.

ChangeLog entry: make rmail-output-read-file-name use rmail-buffer when
in summary

I was unable to download the most recent Emacs from bazaar, but I was
able to get the source from the Ubuntu archive, and I think it is
current in this regard. Because of this, I also had to make a slightly
different diff, but I think it will work. It's only a two-line change
anyway.

Diff:

diff -c -L rmailout.el -L \#\<buffer\ rmailout.el\> rmailout.el /tmp/buffer-content-19356i1B
*** rmailout.el
--- #<buffer rmailout.el>
***************
*** 59,64 ****
--- 59,65 ----
  (defun rmail-output-read-file-name ()
    "Read the file name to use for `rmail-output'.
  Set `rmail-default-file' to this name as well as returning it."
+   (with-current-buffer rmail-buffer
    (let ((default-file
  	  (let (answer tail)
  	    (setq tail rmail-output-file-alist)
***************
*** 87,92 ****
--- 88,94 ----
  	      (expand-file-name
  	       (or read-file (file-name-nondirectory default-file))
  	       (file-name-directory default-file)))))))
+ )
  
  (defun rmail-delete-unwanted-fields (preserve)
    "Delete all headers matching `rmail-fields-not-to-output'.

Diff finished.  Wed Aug 15 15:35:47 2012

All the best,
Terry
-- 
T.F. Torrey

Message #10 received at 12214-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 12214-done <at> debbugs.gnu.org
Subject: Re: bug#12214: rmail-output-read-file-name Error in Summary (with
	Patch)
Date: Fri, 17 Aug 2012 16:39:56 -0400

Version: 24.3

Thanks for the report. I installed a slightly more complicated fix to
the Emacs trunk, currently expected to appear as Emacs 24.3 at some
point.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.