GNU bug report logs - #12117
read-passwd deletes prompt

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#12117: closed (read-passwd deletes prompt)
Date: Wed, 15 Aug 2012 04:13:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 15 Aug 2012 00:03:24 -0400
with message-id <jwvobmcreeq.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#12117: read-passwd deletes prompt
has caused the debbugs.gnu.org bug report #12117,
regarding read-passwd deletes prompt
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
12117: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12117
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Juri Linkov <juri <at> jurta.org>
To: bug-gnu-emacs <at> gnu.org
Subject: read-passwd deletes prompt
Date: Thu, 02 Aug 2012 11:07:06 +0300

A new implementation of `read-passwd' allows the user to delete
characters from the minibuffer's prompt, i.e. when the user
mistypes the password and wants to retype it after clearing with
a few of DELs, typing more DEL will start removing characters
from the prompt.

This can be reproduced by visiting a GPG encrypted file that uses
`epa-passphrase-callback-function' that calls `read-passwd'.

The problem is that `find-file-noselect-1' binds `inhibit-read-only' to t
before calling `insert-file-contents':

            (let ((inhibit-read-only t))
              (insert-file-contents filename t))

The simplest test case to demonstrate the problem is to type DEL
after evaluating:

  (let ((inhibit-read-only t))
    (read-passwd "Password: "))

What is expected is: instead of deleting characters from the prompt
DEL should display the message "Text is read-only".

One solution is to let-bind `inhibit-read-only' to nil either
in `read-passwd' or in `epa-passphrase-callback-function',
or maybe in both?

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Juri Linkov <juri <at> jurta.org>
Cc: 12117-done <at> debbugs.gnu.org
Subject: Re: bug#12117: read-passwd deletes prompt
Date: Wed, 15 Aug 2012 00:03:24 -0400

> One solution is to let-bind `inhibit-read-only' to nil either
> in `read-passwd' or in `epa-passphrase-callback-function',
> or maybe in both?

I've installed a patch which let-binds inhibit-read-only in
read-from-minibuffer.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.