GNU bug report logs - #12117
read-passwd deletes prompt

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12117 in the body.
You can then email your comments to 12117 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: bug-gnu-emacs <at> gnu.org
Subject: read-passwd deletes prompt
Date: Thu, 02 Aug 2012 11:07:06 +0300

A new implementation of `read-passwd' allows the user to delete
characters from the minibuffer's prompt, i.e. when the user
mistypes the password and wants to retype it after clearing with
a few of DELs, typing more DEL will start removing characters
from the prompt.

This can be reproduced by visiting a GPG encrypted file that uses
`epa-passphrase-callback-function' that calls `read-passwd'.

The problem is that `find-file-noselect-1' binds `inhibit-read-only' to t
before calling `insert-file-contents':

            (let ((inhibit-read-only t))
              (insert-file-contents filename t))

The simplest test case to demonstrate the problem is to type DEL
after evaluating:

  (let ((inhibit-read-only t))
    (read-passwd "Password: "))

What is expected is: instead of deleting characters from the prompt
DEL should display the message "Text is read-only".

One solution is to let-bind `inhibit-read-only' to nil either
in `read-passwd' or in `epa-passphrase-callback-function',
or maybe in both?

Message #8 received at 12117 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Juri Linkov <juri <at> jurta.org>
Cc: 12117 <at> debbugs.gnu.org
Subject: Re: bug#12117: read-passwd deletes prompt
Date: Mon, 06 Aug 2012 18:00:09 -0400

> The problem is that `find-file-noselect-1' binds `inhibit-read-only' to t
> before calling `insert-file-contents':

>             (let ((inhibit-read-only t))
>               (insert-file-contents filename t))

Hmm... I guess the problem is even more general: any minibuffer input
during insert-file-contents will suffer from it (granted, there usually
isn't much minibuffer input during such calls, luckily).

Maybe read-from-minibuffer should let-bind inhibit-read-only to nil?
That sounds ugly, tho.


        Stefan

Message #11 received at 12117 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 12117 <at> debbugs.gnu.org
Subject: Re: bug#12117: read-passwd deletes prompt
Date: Tue, 07 Aug 2012 03:04:17 +0300

> Hmm... I guess the problem is even more general: any minibuffer input
> during insert-file-contents will suffer from it (granted, there usually
> isn't much minibuffer input during such calls, luckily).
>
> Maybe read-from-minibuffer should let-bind inhibit-read-only to nil?
> That sounds ugly, tho.

Since there is not much minibuffer input during insert-file-contents
(one is known at the moment) then perhaps it would be safer to fix
just these places specific to insert-file-contents:

=== modified file 'lisp/epa.el'
--- lisp/epa.el	2012-06-08 16:39:49 +0000
+++ lisp/epa.el	2012-08-07 00:01:14 +0000
@@ -589,6 +589,10 @@ (defun epa-display-verify-result (verify
 (make-obsolete 'epa-display-verify-result 'epa-display-info "23.1")
 
 (defun epa-passphrase-callback-function (context key-id handback)
+  ;; Bind `inhibit-read-only' to nil because `find-file-noselect-1' binds
+  ;; it to t (for `insert-file-contents') that allows the user to delete
+  ;; characters in the read-only minibuffer prompt in `read-passwd'.
+  (let ((inhibit-read-only nil))
   (if (eq key-id 'SYM)
       (read-passwd
        (format "Passphrase for symmetric encryption%s: "
@@ -603,7 +607,7 @@ (defun epa-passphrase-callback-function
        (let ((entry (assoc key-id epg-user-id-alist)))
 	 (if entry
 	     (format "Passphrase for %s %s: " key-id (cdr entry))
-	   (format "Passphrase for %s: " key-id)))))))
+	     (format "Passphrase for %s: " key-id))))))))
 
 (defun epa-progress-callback-function (_context what _char current total
 					       handback)

Message #14 received at 12117 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Juri Linkov <juri <at> jurta.org>
Cc: 12117 <at> debbugs.gnu.org
Subject: Re: bug#12117: read-passwd deletes prompt
Date: Tue, 07 Aug 2012 11:08:31 -0400

>> Hmm... I guess the problem is even more general: any minibuffer input
>> during insert-file-contents will suffer from it (granted, there usually
>> isn't much minibuffer input during such calls, luckily).
>> Maybe read-from-minibuffer should let-bind inhibit-read-only to nil?
>> That sounds ugly, tho.
> Since there is not much minibuffer input during insert-file-contents
> (one is known at the moment) then perhaps it would be safer to fix
> just these places specific to insert-file-contents:

No, I'd rather fix it in read-from-minibuffer than in just those
specific cases we bump into.

I think the "right" fix might be to make inhibit-read-only
buffer-local.  But I fear some code relies on it being global, so it
might introduce bugs.


        Stefan

Message #19 received at 12117-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Juri Linkov <juri <at> jurta.org>
Cc: 12117-done <at> debbugs.gnu.org
Subject: Re: bug#12117: read-passwd deletes prompt
Date: Wed, 15 Aug 2012 00:03:24 -0400

> One solution is to let-bind `inhibit-read-only' to nil either
> in `read-passwd' or in `epa-passphrase-callback-function',
> or maybe in both?

I've installed a patch which let-binds inhibit-read-only in
read-from-minibuffer.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.