GNU bug report logs - #12087
Wrong comment in passfd.c?

Previous Next

Full log

Message #7 received at control <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Jann Horn <jannhorn <at> googlemail.com>
Cc: bug-gnulib <bug-gnulib <at> gnu.org>, 12087-done <at> debbugs.gnu.org
Subject: Re: bug#12087: Wrong comment in passfd.c?
Date: Mon, 30 Jul 2012 06:24:21 -0600

[Message part 1 (text/plain, inline)]

tag 12087 fixed
thanks

[adding bug-gnulib, as the source of the bug]

On 07/29/2012 02:14 PM, Jann Horn wrote:
> Hello,
> it looks to me like this comment is wrong:
> 
> gnulib/lib/passfd.c:
> 101 /* recvfd receives a file descriptor through the socket.
> 102    The flags are a bitmask, possibly including O_CLOEXEC (defined in <fcntl.h>).
> 103 
> 104    Return 0 on success, or -1 with errno set in case of error.
> 105 */
> 106 int
> 107 recvfd (int sock, int flags)
> 
> It returns the fd, not 0, on success, right?

You are correct.  Thanks for the report; I've pushed a fix to gnulib.

Coreutils will pick it up on the next gnulib update; but as it is of
minor severity, I'm going to close this coreutils bug report now.  Feel
free to provide further comments!

-- 
Eric Blake   eblake <at> redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.