GNU bug report logs - #12087
Wrong comment in passfd.c?

Previous Next

Package: coreutils;

Reported by: Jann Horn <jannhorn <at> googlemail.com>

Date: Sun, 29 Jul 2012 22:55:01 UTC

Severity: normal

Tags: fixed

Done: Eric Blake <eblake <at> redhat.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12087 in the body.
You can then email your comments to 12087 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-coreutils <at> gnu.org:
bug#12087; Package coreutils. (Sun, 29 Jul 2012 22:55:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Jann Horn <jannhorn <at> googlemail.com>:
New bug report received and forwarded. Copy sent to bug-coreutils <at> gnu.org. (Sun, 29 Jul 2012 22:55:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jann Horn <jannhorn <at> googlemail.com>
To: bug-coreutils <at> gnu.org
Subject: Wrong comment in passfd.c?
Date: Sun, 29 Jul 2012 22:14:15 +0200

[Message part 1 (text/plain, inline)]
Hello,
it looks to me like this comment is wrong:

gnulib/lib/passfd.c:
101 /* recvfd receives a file descriptor through the socket.
102    The flags are a bitmask, possibly including O_CLOEXEC (defined in <fcntl.h>).
103 
104    Return 0 on success, or -1 with errno set in case of error.
105 */
106 int
107 recvfd (int sock, int flags)

It returns the fd, not 0, on success, right?

Jann

[Message part 2 (application/pgp-signature, inline)]
Added tag(s) fixed. Request was from Eric Blake <eblake <at> redhat.com> to control <at> debbugs.gnu.org. (Mon, 30 Jul 2012 12:32:01 GMT) Full text and rfc822 format available.
Reply sent to Eric Blake <eblake <at> redhat.com>:
You have taken responsibility. (Mon, 30 Jul 2012 12:32:02 GMT) Full text and rfc822 format available.
Notification sent to Jann Horn <jannhorn <at> googlemail.com>:
bug acknowledged by developer. (Mon, 30 Jul 2012 12:32:02 GMT) Full text and rfc822 format available.

Message #12 received at 12087-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Jann Horn <jannhorn <at> googlemail.com>
Cc: bug-gnulib <bug-gnulib <at> gnu.org>, 12087-done <at> debbugs.gnu.org
Subject: Re: bug#12087: Wrong comment in passfd.c?
Date: Mon, 30 Jul 2012 06:24:21 -0600

[Message part 1 (text/plain, inline)]
tag 12087 fixed
thanks

[adding bug-gnulib, as the source of the bug]

On 07/29/2012 02:14 PM, Jann Horn wrote:
> Hello,
> it looks to me like this comment is wrong:
> 
> gnulib/lib/passfd.c:
> 101 /* recvfd receives a file descriptor through the socket.
> 102    The flags are a bitmask, possibly including O_CLOEXEC (defined in <fcntl.h>).
> 103 
> 104    Return 0 on success, or -1 with errno set in case of error.
> 105 */
> 106 int
> 107 recvfd (int sock, int flags)
> 
> It returns the fd, not 0, on success, right?

You are correct.  Thanks for the report; I've pushed a fix to gnulib.

Coreutils will pick it up on the next gnulib update; but as it is of
minor severity, I'm going to close this coreutils bug report now.  Feel
free to provide further comments!

-- 
Eric Blake   eblake <at> redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[signature.asc (application/pgp-signature, attachment)]
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 28 Aug 2012 11:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 12 years and 297 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.