GNU bug report logs - #12030
24.0.97; y-or-n-p and redirect-frame-focus

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: martin rudalics <rudalics <at> gmx.at>
Subject: bug#12030: closed (Re: bug#12030: 24.0.97; y-or-n-p and
 redirect-frame-focus)
Date: Wed, 25 Jul 2012 09:54:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#12030: 24.0.97; y-or-n-p and redirect-frame-focus

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 12030 <at> debbugs.gnu.org.

-- 
12030: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12030
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: martin rudalics <rudalics <at> gmx.at>
To: 12030-done <at> debbugs.gnu.org
Cc: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Subject: Re: bug#12030: 24.0.97; y-or-n-p and redirect-frame-focus
Date: Wed, 25 Jul 2012 11:46:41 +0200

> I think you're right.  Could you make it "soft-mandatory" by adding
> an `advertised-signature'?

Done.

martin

[Message part 3 (message/rfc822, inline)]

From: martin rudalics <rudalics <at> gmx.at>
To: Bug-Gnu-Emacs <bug-gnu-emacs <at> gnu.org>
Subject: 24.0.97; y-or-n-p and redirect-frame-focus
Date: Mon, 23 Jul 2012 11:35:13 +0200

`yes-or-no-p' eventually winds up calling read_minibuf which does

  if (minibuffer_auto_raise)
    Fraise_frame (mini_frame);
  ...
  if (!EQ (mini_frame, selected_frame))
    Fredirect_frame_focus (selected_frame, mini_frame);

`y-or-n-p' instead does

                    (when minibuffer-auto-raise
		      (raise-frame (window-frame (minibuffer-window))))
		    ...
		    (redirect-frame-focus (window-frame (minibuffer-window)))

which strikes me as incongruent with the former since IIUC the last form
only redirects the minibuffer-window frame's focus to itself.  If this
is not the intended behavior, a possible source of the bug is that the
second argument of `redirect-frame-focus' is not mandatory.  As a
consequence, authors (including me) tend to consider its first argument
reference the frame that shall be focused.

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.