GNU bug report logs - #12030
24.0.97; y-or-n-p and redirect-frame-focus

Previous Next

Package: emacs;

Reported by: martin rudalics <rudalics <at> gmx.at>

Date: Mon, 23 Jul 2012 09:42:01 UTC

Severity: normal

Found in version 24.0.97

Done: martin rudalics <rudalics <at> gmx.at>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12030 in the body.
You can then email your comments to 12030 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#12030; Package emacs. (Mon, 23 Jul 2012 09:42:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to martin rudalics <rudalics <at> gmx.at>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 23 Jul 2012 09:42:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Bug-Gnu-Emacs <bug-gnu-emacs <at> gnu.org>
Subject: 24.0.97; y-or-n-p and redirect-frame-focus
Date: Mon, 23 Jul 2012 11:35:13 +0200

`yes-or-no-p' eventually winds up calling read_minibuf which does

  if (minibuffer_auto_raise)
    Fraise_frame (mini_frame);
  ...
  if (!EQ (mini_frame, selected_frame))
    Fredirect_frame_focus (selected_frame, mini_frame);

`y-or-n-p' instead does

                    (when minibuffer-auto-raise
		      (raise-frame (window-frame (minibuffer-window))))
		    ...
		    (redirect-frame-focus (window-frame (minibuffer-window)))

which strikes me as incongruent with the former since IIUC the last form
only redirects the minibuffer-window frame's focus to itself.  If this
is not the intended behavior, a possible source of the bug is that the
second argument of `redirect-frame-focus' is not mandatory.  As a
consequence, authors (including me) tend to consider its first argument
reference the frame that shall be focused.

martin
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#12030; Package emacs. (Mon, 23 Jul 2012 10:16:01 GMT) Full text and rfc822 format available.

Message #8 received at 12030 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 12030 <at> debbugs.gnu.org
Subject: Re: bug#12030: 24.0.97; y-or-n-p and redirect-frame-focus
Date: Mon, 23 Jul 2012 06:08:55 -0400

> only redirects the minibuffer-window frame's focus to itself.  If this
> is not the intended behavior, a possible source of the bug is that the
> second argument of `redirect-frame-focus' is not mandatory.  As a

I think you're right.  Could you make it "soft-mandatory" by adding
an `advertised-signature'?


        Stefan
Reply sent to martin rudalics <rudalics <at> gmx.at>:
You have taken responsibility. (Wed, 25 Jul 2012 09:54:01 GMT) Full text and rfc822 format available.
Notification sent to martin rudalics <rudalics <at> gmx.at>:
bug acknowledged by developer. (Wed, 25 Jul 2012 09:54:02 GMT) Full text and rfc822 format available.

Message #13 received at 12030-done <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: 12030-done <at> debbugs.gnu.org
Cc: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Subject: Re: bug#12030: 24.0.97; y-or-n-p and redirect-frame-focus
Date: Wed, 25 Jul 2012 11:46:41 +0200

> I think you're right.  Could you make it "soft-mandatory" by adding
> an `advertised-signature'?

Done.

martin
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 22 Aug 2012 11:24:02 GMT) Full text and rfc822 format available.
This bug report was last modified 13 years and 22 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.