GNU bug report logs - #11981
24.1.50; url-http-parse-headers should not disable file name handlers since it breaks auth-source

Previous Next

Full log

View this message in rfc822 format

From: David Engster <deng <at> randomsample.de>
To: Jan Djärv <jan.h.d <at> swipnet.se>
Cc: 11981 <at> debbugs.gnu.org, Michael Albinus <michael.albinus <at> gmx.de>, Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Subject: bug#11981: 24.1.50; url-http-parse-headers should not disable file name handlers since it breaks auth-source
Date: Sun, 12 Aug 2012 16:52:47 +0200

Jan Djärv writes:
> Hello.
>
> 6 aug 2012 kl. 18:01 skrev Stefan Monnier:
>
>>> @@ -246,18 +246,24 @@
>>>   "Return the directory part of FILE, for a URL."
>>>   (cond
>>>    ((null file) "")
>>> -   ((string-match "\\?" file)
>>> -    (file-name-directory (substring file 0 (match-beginning 0))))
>>> -   (t (file-name-directory file))))
>>> +   ((string-match "\\(\\?\\|%3[fF]\\)" file)
>>> +    (url-file-directory (substring file 0 (match-beginning 0))))
>> 
>> Should %3F really be treated like a ? (i.e. a special char that
>> delimits two different parts of a URL) rather than like "a normal ?
>> character encoded so as not to delimit two different parts of a URL"?
>> 
>
> A normal non-delimiting ?.  How else can one get a ? in to an URL?

You are both right, of course; I was overcompensating. The match for
%3[fF] must be removed.

-David

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.