GNU bug report logs - #11980
Other expirable marks lost if non-native articles are expired

Previous Next

Package: gnus;

Reported by: Dave Abrahams <dave <at> boostpro.com>

Date: Wed, 18 Jul 2012 17:42:02 UTC

Severity: normal

Tags: fixed

Found in version 5.130006

Fixed in version 24.3

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11980 in the body.
You can then email your comments to 11980 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bugs <at> gnus.org:
bug#11980; Package gnus. (Wed, 18 Jul 2012 17:42:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Dave Abrahams <dave <at> boostpro.com>:
New bug report received and forwarded. Copy sent to bugs <at> gnus.org. (Wed, 18 Jul 2012 17:42:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dave Abrahams <dave <at> boostpro.com>
To: submit <at> debbugs.gnu.org (The Gnus Bugfixing Girls + Boys)
Subject: Other expirable marks lost if non-native articles are expired
Date: Wed, 18 Jul 2012 13:35:29 -0400
I'm forever bringing articles into my INBOX via gnus-summary-refer-*
functions.  Oftentimes I mark these articles expirable, along with some
others, and the `M-g' to get Gnus to actually delete them (that's what
expiry does in my INBOX: immediate deletion).  Gnus, however, leaves the
articles there.  To get rid of them, I have to be very careful *not* to
mark any articles that have been inserted from other groups as expirable.




Ma Gnus v0.6
GNU Emacs 24.1.1 (x86_64-apple-darwin11.4.0, Carbon Version 1.6.0 AppKit 1138.47)
 of 2012-06-27 on pluto.luannocracy.com
200 news.gmane.org InterNetNews NNRP server INN 2.5.1 ready (posting ok)
101 Capability list:
VERSION 2
IMPLEMENTATION INN 2.5.1
AUTHINFO USER
HDR
LIST ACTIVE ACTIVE.TIMES DISTRIB.PATS HEADERS NEWSGROUPS OVERVIEW.FMT
OVER
POST
READER
STARTTLS
.
382 Begin TLS negotiation now
101 Capability list:
VERSION 2
IMPLEMENTATION INN 2.5.1
AUTHINFO USER
HDR
LIST ACTIVE ACTIVE.TIMES DISTRIB.PATS HEADERS NEWSGROUPS OVERVIEW.FMT
OVER
POST
READER
.

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com





Information forwarded to bugs <at> gnus.org:
bug#11980; Package gnus. (Wed, 18 Jul 2012 18:20:01 GMT) Full text and rfc822 format available.

Message #8 received at 11980 <at> debbugs.gnu.org (full text, mbox):

From: Dave Abrahams <dave <at> boostpro.com>
To: 11980 <at> debbugs.gnu.org
Subject: Re: bug#11980: [PATCH] Other expirable marks lost if non-native
	articles are expired
Date: Wed, 18 Jul 2012 14:13:19 -0400
[Message part 1 (text/plain, inline)]
And here's the patch that fixes it:

[gnus-int.patch (text/x-patch, inline)]
diff --git a/lisp/gnus-int.el b/lisp/gnus-int.el
index 18e56ed..d4a52ed 100644
--- a/lisp/gnus-int.el
+++ b/lisp/gnus-int.el
@@ -722,6 +722,10 @@ If GROUP is nil, all groups on GNUS-COMMAND-METHOD are scanned."
 
 (defun gnus-request-expire-articles (articles group &optional force)
   (let* ((gnus-command-method (gnus-find-method-for-group group))
+         ;; Filter out any negative article numbers; they can't be
+         ;; expired here.
+         (articles
+          (delq nil (mapcar (lambda (n) (and (>= n 0) n)) articles)))
 	 (gnus-inhibit-demon t)
 	 (not-deleted
 	  (funcall
[Message part 3 (text/plain, inline)]
on Wed Jul 18 2012, Dave Abrahams <dave-AT-boostpro.com> wrote:

> I'm forever bringing articles into my INBOX via gnus-summary-refer-*
> functions.  Oftentimes I mark these articles expirable, along with some
> others, and the `M-g' to get Gnus to actually delete them (that's what
> expiry does in my INBOX: immediate deletion).  Gnus, however, leaves the
> articles there.  To get rid of them, I have to be very careful *not* to
> mark any articles that have been inserted from other groups as expirable.
>
> Ma Gnus v0.6
> GNU Emacs 24.1.1 (x86_64-apple-darwin11.4.0, Carbon Version 1.6.0 AppKit 1138.47)
>  of 2012-06-27 on pluto.luannocracy.com
> 200 news.gmane.org InterNetNews NNRP server INN 2.5.1 ready (posting ok)
> 101 Capability list:
> VERSION 2
> IMPLEMENTATION INN 2.5.1
> AUTHINFO USER
> HDR
> LIST ACTIVE ACTIVE.TIMES DISTRIB.PATS HEADERS NEWSGROUPS OVERVIEW.FMT
> OVER
> POST
> READER
> STARTTLS
> .
> 382 Begin TLS negotiation now
> 101 Capability list:
> VERSION 2
> IMPLEMENTATION INN 2.5.1
> AUTHINFO USER
> HDR
> LIST ACTIVE ACTIVE.TIMES DISTRIB.PATS HEADERS NEWSGROUPS OVERVIEW.FMT
> OVER
> POST
> READER
> .

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com

Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 05 Sep 2012 19:09:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 24.3, send any further explanations to 11980 <at> debbugs.gnu.org and Dave Abrahams <dave <at> boostpro.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 05 Sep 2012 19:09:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 04 Oct 2012 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 12 years and 262 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.