GNU bug report logs - #11880
24.1.50; `even-window-heights' should be nil by default

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11880 in the body.
You can then email your comments to 11880 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.1.50; `even-window-heights' should be nil by default
Date: Sun, 08 Jul 2012 21:03:24 +0400

As mentioned in http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11810,
I believe that the behavior enabled by this variable is non-intuitive
and inconsistent.

Many users have become used to it, but looks like the majority just
doesn't know how to disable it. Example:
http://stackoverflow.com/questions/4716855/how-can-i-prevent-emacs-resizing-my-windows

A question to people who like it as it is: what's the idea behind the
window position limitations? Why only resize when the used window is
vertically adjacent to the selected, and only when below it?
Why not resize independent of position, as long as the used window is inside
some vertically split combination?

As alternative to disabling it by default, I propose to
1) Make `window--even-window-heights' resize any window as long as that
would only move the window(s) in the same combination (or something like
that).
2) Restore the original window height on `quit-window'. This amounts to
the following code at the end of `display-buffer-user-some-window':

  (when window
    (prog1
      (window--display-buffer buffer window 'reuse)
      (window--even-window-heights window)))

--Dmitry

GNU Emacs 24.1.50.1 (i386-mingw-nt6.1.7601) of 2012-07-06

Message #8 received at 11880 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: 11880 <at> debbugs.gnu.org
Subject: Re: bug#11880: Acknowledgement (24.1.50; `even-window-heights' should
	be nil by default)
Date: Thu, 12 Jul 2012 22:52:58 +0400

Oh, and by the way, `even-window-heights' docstring is incorrect.

It says: "Heights are evened only when `display-buffer' chooses a
window that appears above or below the selected window."
Whereas heights will only be evened if the chosen window is below the 
selected window.

Message #13 received at 11880 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 11880 <at> debbugs.gnu.org
Subject: Re: bug#11880: 24.1.50; `even-window-heights' should be nil by default
Date: Sat, 25 Aug 2012 16:57:24 +0200

> As alternative to disabling it by default, I propose to
> 1) Make `window--even-window-heights' resize any window as long as that
> would only move the window(s) in the same combination (or something like
> that).

I now resize only when WINDOW and the selected window form a combination.

> 2) Restore the original window height on `quit-window'. This amounts to
> the following code at the end of `display-buffer-user-some-window':
>
>   (when window
>     (prog1
>       (window--display-buffer buffer window 'reuse)
>       (window--even-window-heights window)))

It should do that now.

martin

Message #16 received at 11880 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 11880 <at> debbugs.gnu.org
Subject: Re: bug#11880: Acknowledgement (24.1.50; `even-window-heights' should
	be nil by default)
Date: Sat, 25 Aug 2012 16:57:41 +0200

> Oh, and by the way, `even-window-heights' docstring is incorrect.
> 
> It says: "Heights are evened only when `display-buffer' chooses a
> window that appears above or below the selected window."
> Whereas heights will only be evened if the chosen window is below the 
> selected window.

It now should even in either case.

martin

Message #19 received at 11880 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 11880 <at> debbugs.gnu.org
Subject: Re: bug#11880: 24.1.50; `even-window-heights' should be nil by default
Date: Sun, 26 Aug 2012 02:28:59 +0400

On 25.08.2012 18:57, martin rudalics wrote:
>  > As alternative to disabling it by default, I propose to
>  > 1) Make `window--even-window-heights' resize any window as long as that
>  > would only move the window(s) in the same combination (or something like
>  > that).
>
> I now resize only when WINDOW and the selected window form a combination.
>
>  > 2) Restore the original window height on `quit-window'. This amounts to
>  > the following code at the end of `display-buffer-user-some-window':
>  >
>  >   (when window
>  >     (prog1
>  >       (window--display-buffer buffer window 'reuse)
>  >       (window--even-window-heights window)))
>
> It should do that now.

Indeed, the behavior is much better now. Thanks!

--Dmitry

Message #24 received at 11880-done <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: 11880-done <at> debbugs.gnu.org
Cc: Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#11880: 24.1.50; `even-window-heights' should be nil by default
Date: Mon, 27 Aug 2012 11:16:29 +0200

> Indeed, the behavior is much better now. Thanks!

The behavior is since revision 109773 on trunk.  Bug closed.

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.