GNU bug report logs - #11824
[PATCH] gnus-warp-to-article broken with nnir

Previous Next

Full log

View this message in rfc822 format

From: Dave Abrahams <dave <at> boostpro.com>
To: Wolfgang Jenkner <wjenkner <at> inode.at>
Cc: 11824 <at> debbugs.gnu.org
Subject: bug#11824: [PATCH] gnus-warp-to-article broken with nnir
Date: Sat, 21 Jul 2012 09:50:06 -0400

on Sat Jul 21 2012, Wolfgang Jenkner <wjenkner-AT-inode.at> wrote:

> On Sat, Jul 21 2012, Dave Abrahams wrote:
>
>> Generally I do nnir searches in my "All Mail" archive folder,
>> which is enormous.  It's extremely fast, because it's backed by a local
>> IMAP server.  However, when I try to warp to the article, Gnus wants
>> open a summary on that buffer and show ALL ARTICLES, which is
>> intolerably slow and memory-consumptive.
>
> When I do an nnir search in a gmane newsgroup, warping to an article
> results in a summary which contains only this article but neither new
> nor ticked articles.  

Actually, me too. I think I was just misinterpreting the 2nd argument to
gnus-summary-read-group-1 in 

--8<---------------cut here---------------start------------->8---
(deffoo nnir-warp-to-article ()
  (let* ((cur (if (> (gnus-summary-article-number) 0)
		  (gnus-summary-article-number)
		(error "This is not a real article")))
	 (backend-article-group (nnir-article-group cur))
         (backend-article-number (nnir-article-number cur))
	 (quit-config (gnus-ephemeral-group-p gnus-newsgroup-name)))
    ;; first exit from the nnir summary buffer.
    (gnus-summary-exit)
    ;; and if the nnir summary buffer in turn came from another
    ;; summary buffer we have to clean that summary up too.
    (when (eq (cdr quit-config) 'summary)
      (gnus-summary-exit))
    (gnus-summary-read-group-1 backend-article-group t t  nil 
;; HERE----------------------------------------------^
			       nil (list backend-article-number))))
--8<---------------cut here---------------end--------------->8---

and the culprit was really the big O(N^2) cost of gnus-set-difference
(addressed with the patch I cited).

> IIUC, we have got complementary use cases :-)

I'm not so sure anymore. :-)

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.