GNU bug report logs - #11824
[PATCH] gnus-warp-to-article broken with nnir

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11824 in the body.
You can then email your comments to 11824 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Wolfgang Jenkner <wjenkner <at> inode.at>
To: submit <at> debbugs.gnu.org (The Gnus Bugfixing Girls + Boys)
Cc: Dave Abrahams <dave <at> boostpro.com>
Subject: [PATCH] gnus-warp-to-article broken with nnir
Date: Sat, 30 Jun 2012 15:11:40 +0200

In the *Group* buffer, with point on, say, gmane.emacs.devel type

G G V i SPC r u l e s <return> A W 

You should be in *Summary gmane.emacs.devel* now, but you are still in
*Summary nnir:((query . \"Vi rules\") (unique-id . \"857gup4ie7.fsf\"))*
or something like that.

Ma Gnus v0.6
GNU Emacs 24.1.50.1 (amd64-unknown-freebsd9.0, GTK+ Version 2.24.6)
 of 2012-06-23 on iznogoud.viz

2012-06-30  Wolfgang Jenkner  <wjenkner <at> inode.at>

	* nnir.el (gnus-declare-backend): Add `virtual' as ability.

	This is necessary because gnus-warp-to-article now checks beforehand
	that the current group is virtual.


-- >8 --
Subject: [PATCH] Add `virtual' to the nnir abilities in gnus-declare-backend.

This is necessary because of 6ff4928b279b6c343f28642da8882a63631f1674.
---
 lisp/nnir.el |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/nnir.el b/lisp/nnir.el
index d1ca021..70df929 100644
--- a/lisp/nnir.el
+++ b/lisp/nnir.el
@@ -298,7 +298,7 @@ is `(valuefunc member)'."
 (defvoo nnir-address nil
   "The address of the nnir server.")
 
-(gnus-declare-backend "nnir" 'mail)
+(gnus-declare-backend "nnir" 'mail 'virtual)
 
 
 ;;; User Customizable Variables:
-- 
1.7.10.3

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dave Abrahams <dave <at> boostpro.com>
To: Wolfgang Jenkner <wjenkner <at> inode.at>
Cc: The Gnus Bugfixing Girls + Boys <submit <at> debbugs.gnu.org>
Subject: Re: [PATCH] gnus-warp-to-article broken with nnir
Date: Fri, 20 Jul 2012 19:50:29 -0400

on Sat Jun 30 2012, Wolfgang Jenkner <wjenkner-AT-inode.at> wrote:

> In the *Group* buffer, with point on, say, gmane.emacs.devel type
>
> G G V i SPC r u l e s <return> A W 
>
> You should be in *Summary gmane.emacs.devel* now, but you are still in
> *Summary nnir:((query . \"Vi rules\") (unique-id . \"857gup4ie7.fsf\"))*
> or something like that.

<schnipp>

> diff --git a/lisp/nnir.el b/lisp/nnir.el
> index d1ca021..70df929 100644
> --- a/lisp/nnir.el
> +++ b/lisp/nnir.el
> @@ -298,7 +298,7 @@ is `(valuefunc member)'."
>  (defvoo nnir-address nil
>    "The address of the nnir server.")
>
> -(gnus-declare-backend "nnir" 'mail)
> +(gnus-declare-backend "nnir" 'mail 'virtual)
>
>  ;;; User Customizable Variables:

This patch seems reasonable to me, but it brings up a new problem (for
me).  Generally I do nnir searches in my "All Mail" archive folder,
which is enormous.  It's extremely fast, because it's backed by a local
IMAP server.  However, when I try to warp to the article, Gnus wants
open a summary on that buffer and show ALL ARTICLES, which is
intolerably slow and memory-consumptive.  Not sure how to address this yet.

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dave Abrahams <dave <at> boostpro.com>
To: Wolfgang Jenkner <wjenkner <at> inode.at>
Cc: The Gnus Bugfixing Girls + Boys <submit <at> debbugs.gnu.org>
Subject: Re: [PATCH] gnus-warp-to-article broken with nnir
Date: Fri, 20 Jul 2012 21:28:22 -0400

On Fri, Jul 20, 2012 at 7:50 PM, Dave Abrahams <dave <at> boostpro.com> wrote:
>
> on Sat Jun 30 2012, Wolfgang Jenkner <wjenkner-AT-inode.at> wrote:
>
>> In the *Group* buffer, with point on, say, gmane.emacs.devel type
>>
>> G G V i SPC r u l e s <return> A W
>>
>> You should be in *Summary gmane.emacs.devel* now, but you are still in
>> *Summary nnir:((query . \"Vi rules\") (unique-id . \"857gup4ie7.fsf\"))*
>> or something like that.
>
> <schnipp>
>
>> diff --git a/lisp/nnir.el b/lisp/nnir.el
>> index d1ca021..70df929 100644
>> --- a/lisp/nnir.el
>> +++ b/lisp/nnir.el
>> @@ -298,7 +298,7 @@ is `(valuefunc member)'."
>>  (defvoo nnir-address nil
>>    "The address of the nnir server.")
>>
>> -(gnus-declare-backend "nnir" 'mail)
>> +(gnus-declare-backend "nnir" 'mail 'virtual)
>>
>>  ;;; User Customizable Variables:
>
> This patch seems reasonable to me, but it brings up a new problem (for
> me).  Generally I do nnir searches in my "All Mail" archive folder,
> which is enormous.  It's extremely fast, because it's backed by a local
> IMAP server.  However, when I try to warp to the article, Gnus wants
> open a summary on that buffer and show ALL ARTICLES, which is
> intolerably slow and memory-consumptive.  Not sure how to address this yet.

But now I do:
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12003

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com

Message #14 received at 11824 <at> debbugs.gnu.org (full text, mbox):

From: Wolfgang Jenkner <wjenkner <at> inode.at>
To: Dave Abrahams <dave <at> boostpro.com>
Cc: 11824 <at> debbugs.gnu.org
Subject: Re: bug#11824: [PATCH] gnus-warp-to-article broken with nnir
Date: Sat, 21 Jul 2012 13:55:21 +0200

On Sat, Jul 21 2012, Dave Abrahams wrote:

> Generally I do nnir searches in my "All Mail" archive folder,
> which is enormous.  It's extremely fast, because it's backed by a local
> IMAP server.  However, when I try to warp to the article, Gnus wants
> open a summary on that buffer and show ALL ARTICLES, which is
> intolerably slow and memory-consumptive.

When I do an nnir search in a gmane newsgroup, warping to an article
results in a summary which contains only this article but neither new
nor ticked articles.  IIUC, we have got complementary use cases :-)

Wolfgang

Message #17 received at 11824 <at> debbugs.gnu.org (full text, mbox):

From: Dave Abrahams <dave <at> boostpro.com>
To: Wolfgang Jenkner <wjenkner <at> inode.at>
Cc: 11824 <at> debbugs.gnu.org
Subject: Re: bug#11824: [PATCH] gnus-warp-to-article broken with nnir
Date: Sat, 21 Jul 2012 09:50:06 -0400

on Sat Jul 21 2012, Wolfgang Jenkner <wjenkner-AT-inode.at> wrote:

> On Sat, Jul 21 2012, Dave Abrahams wrote:
>
>> Generally I do nnir searches in my "All Mail" archive folder,
>> which is enormous.  It's extremely fast, because it's backed by a local
>> IMAP server.  However, when I try to warp to the article, Gnus wants
>> open a summary on that buffer and show ALL ARTICLES, which is
>> intolerably slow and memory-consumptive.
>
> When I do an nnir search in a gmane newsgroup, warping to an article
> results in a summary which contains only this article but neither new
> nor ticked articles.  

Actually, me too. I think I was just misinterpreting the 2nd argument to
gnus-summary-read-group-1 in 

--8<---------------cut here---------------start------------->8---
(deffoo nnir-warp-to-article ()
  (let* ((cur (if (> (gnus-summary-article-number) 0)
		  (gnus-summary-article-number)
		(error "This is not a real article")))
	 (backend-article-group (nnir-article-group cur))
         (backend-article-number (nnir-article-number cur))
	 (quit-config (gnus-ephemeral-group-p gnus-newsgroup-name)))
    ;; first exit from the nnir summary buffer.
    (gnus-summary-exit)
    ;; and if the nnir summary buffer in turn came from another
    ;; summary buffer we have to clean that summary up too.
    (when (eq (cdr quit-config) 'summary)
      (gnus-summary-exit))
    (gnus-summary-read-group-1 backend-article-group t t  nil 
;; HERE----------------------------------------------^
			       nil (list backend-article-number))))
--8<---------------cut here---------------end--------------->8---

and the culprit was really the big O(N^2) cost of gnus-set-difference
(addressed with the patch I cited).

> IIUC, we have got complementary use cases :-)

I'm not so sure anymore. :-)

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com

Message #20 received at 11824 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Wolfgang Jenkner <wjenkner <at> inode.at>
Cc: Dave Abrahams <dave <at> boostpro.com>, 11824 <at> debbugs.gnu.org
Subject: Re: bug#11824: [PATCH] gnus-warp-to-article broken with nnir
Date: Wed, 05 Sep 2012 21:01:23 +0200

Wolfgang Jenkner <wjenkner <at> inode.at> writes:

> 2012-06-30  Wolfgang Jenkner  <wjenkner <at> inode.at>
>
> 	* nnir.el (gnus-declare-backend): Add `virtual' as ability.

This seems to be applied, so I'm closing this report.

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Lars Magne Ingebrigtsen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.