GNU bug report logs - #11388
24.0.95; Improper kill-line in zone.el

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "Aaron S. Hawley" <aaron.s.hawley <at> gmail.com>
Subject: bug#11388: closed (Re: bug#11388: 24.0.95; Improper kill-line in
 zone.el)
Date: Tue, 08 May 2012 01:44:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#11388: 24.0.95; Improper kill-line in zone.el

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 11388 <at> debbugs.gnu.org.

-- 
11388: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11388
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 11388-done <at> debbugs.gnu.org
Subject: Re: bug#11388: 24.0.95; Improper kill-line in zone.el
Date: Mon, 07 May 2012 21:41:08 -0400

Version: 24.2

"Aaron S. Hawley" wrote:

> -         (let ((kill-whole-line t))
> -           (kill-line))
> +         (delete-region (point) (line-end-position))

These don't treat newlines the same. I installed:

 (delete-region (point) (line-beginning-position 2))

[Message part 3 (message/rfc822, inline)]

From: "Aaron S. Hawley" <aaron.s.hawley <at> gmail.com>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: 24.0.95; Improper kill-line in zone.el
Date: Tue, 1 May 2012 10:13:52 -0400

I noticed that my last kill and the desktop clipboard were being
overwritten when Emacs was zoning.  This is because one of the zone
programs uses kill-line.

Reproduce with:

(let ((zone-programs '(zone-pgm-stress)))
    (zone))

Here's a patch:

2012-04-25  Aaron S. Hawley  <aaron.s.hawley <at> gmail.com>

        * zone.el (zone-pgm-stress): Use delete-region instead of kill-line
        unless munging the kill ring is part of the "stress".

--- zone.el	2012-04-25 15:53:42.291906100 -0400
+++ zone.el	2012-04-25 16:11:00.042670800 -0400
@@ -595,8 +595,7 @@
        (when (< 50 (random 100))
          (goto-char (point-max))
          (forward-line -1)
-         (let ((kill-whole-line t))
-           (kill-line))
+         (delete-region (point) (line-end-position))
          (goto-char (point-min))
          (insert (nth (random (length lines)) lines)))
        (message (concat (make-string (random (- (frame-width) 5)) ? ) "grrr"))

Thanks for Emacs.
aaron

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.