GNU bug report logs - #11388
24.0.95; Improper kill-line in zone.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11388 in the body.
You can then email your comments to 11388 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Aaron S. Hawley" <aaron.s.hawley <at> gmail.com>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: 24.0.95; Improper kill-line in zone.el
Date: Tue, 1 May 2012 10:13:52 -0400

I noticed that my last kill and the desktop clipboard were being
overwritten when Emacs was zoning.  This is because one of the zone
programs uses kill-line.

Reproduce with:

(let ((zone-programs '(zone-pgm-stress)))
    (zone))

Here's a patch:

2012-04-25  Aaron S. Hawley  <aaron.s.hawley <at> gmail.com>

        * zone.el (zone-pgm-stress): Use delete-region instead of kill-line
        unless munging the kill ring is part of the "stress".

--- zone.el	2012-04-25 15:53:42.291906100 -0400
+++ zone.el	2012-04-25 16:11:00.042670800 -0400
@@ -595,8 +595,7 @@
        (when (< 50 (random 100))
          (goto-char (point-max))
          (forward-line -1)
-         (let ((kill-whole-line t))
-           (kill-line))
+         (delete-region (point) (line-end-position))
          (goto-char (point-min))
          (insert (nth (random (length lines)) lines)))
        (message (concat (make-string (random (- (frame-width) 5)) ? ) "grrr"))

Thanks for Emacs.
aaron

Message #10 received at 11388-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 11388-done <at> debbugs.gnu.org
Subject: Re: bug#11388: 24.0.95; Improper kill-line in zone.el
Date: Mon, 07 May 2012 21:41:08 -0400

Version: 24.2

"Aaron S. Hawley" wrote:

> -         (let ((kill-whole-line t))
> -           (kill-line))
> +         (delete-region (point) (line-end-position))

These don't treat newlines the same. I installed:

 (delete-region (point) (line-beginning-position 2))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.