GNU bug report logs - #11248
Problems with article search Keys in Summary

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11248 in the body.
You can then email your comments to 11248 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: submit <at> debbugs.gnu.org (The Gnus Bugfixing Girls + Boys)
Subject: Problems with article search Keys in Summary
Date: Sun, 15 Apr 2012 20:55:41 +0200

Hi,

These are the article search key bindings in `gnus-summary-mode-map':

  "\M-s" gnus-summary-search-article-forward
  "\M-r" gnus-summary-search-article-backward
  "\M-S" gnus-summary-repeat-search-article-forward
  "\M-R" gnus-summary-repeat-search-article-backward

I want to make the proposal to move the first two to something
different, maybe C-S and C-R.

Background:

M-s is already a prefix key in the global-map in modern Emacsen.  The
binding of M-s in `gnus-summary-mode-map' shadows it.

But it becomes worse: If a minor-mode (like icicles-mode indeed does)
adds bindings to the M-s prefix in its minor-mode-map, the minor
mode binding shadows M-s in the gnus-summary-mode-map, so that
`gnus-summary-search-article-forward' is unreachable with keys!  You
have to call it with M-x.  Bad.


Regards,

Michael.


Gnus v5.13
GNU Emacs 24.1.50.1 (i486-pc-linux-gnu, GTK+ Version 3.2.3)
 of 2012-04-10 on zelenka, modified by Debian
201 news.cambrium.nl NNRP Service Ready (no posting).
500 What?

Message #8 received at 11248 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 11248 <at> debbugs.gnu.org
Subject: Re: bug#11248: Problems with article search Keys in Summary
Date: Wed, 05 Sep 2012 19:23:01 +0200

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

> These are the article search key bindings in `gnus-summary-mode-map':
>
>   "\M-s" gnus-summary-search-article-forward
>   "\M-r" gnus-summary-search-article-backward
>   "\M-S" gnus-summary-repeat-search-article-forward
>   "\M-R" gnus-summary-repeat-search-article-backward
>
> I want to make the proposal to move the first two to something
> different, maybe C-S and C-R.

`C-s' is a very useful command.  None of the commands under `M-s' seem
particularly useful in the summary buffer.

> But it becomes worse: If a minor-mode (like icicles-mode indeed does)
> adds bindings to the M-s prefix in its minor-mode-map, the minor
> mode binding shadows M-s in the gnus-summary-mode-map, so that
> `gnus-summary-search-article-forward' is unreachable with keys!  You
> have to call it with M-x.  Bad.

Are there any icicles-mode commands that are useful in the summary
buffer?

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Lars Magne Ingebrigtsen

Message #11 received at 11248 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 11248 <at> debbugs.gnu.org
Subject: Re: bug#11248: Problems with article search Keys in Summary
Date: Thu, 06 Sep 2012 21:35:10 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Michael Heerdegen <michael_heerdegen <at> web.de> writes:
>
> > These are the article search key bindings in `gnus-summary-mode-map':
> >
> >   "\M-s" gnus-summary-search-article-forward
> >   "\M-r" gnus-summary-search-article-backward
> >   "\M-S" gnus-summary-repeat-search-article-forward
> >   "\M-R" gnus-summary-repeat-search-article-backward
> >
> > I want to make the proposal to move the first two to something
> > different, maybe C-S and C-R.
>
> `C-s' is a very useful command.

I don't understand how `C-s' is involved here.  I meant C-S, meaning
C-S-s.

> None of the commands under `M-s' seem particularly useful in the
> summary buffer.

Right.

> > But it becomes worse: If a minor-mode (like icicles-mode indeed does)
> > adds bindings to the M-s prefix in its minor-mode-map, the minor
> > mode binding shadows M-s in the gnus-summary-mode-map, so that
> > `gnus-summary-search-article-forward' is unreachable with keys!  You
> > have to call it with M-x.  Bad.
>
> Are there any icicles-mode commands that are useful in the summary
> buffer?

Icicles uses M-s M-s as a prefix for all its several search commands -
no doubt some of them could indeed be useful in the summary buffer,
e.g. M-s M-s l (`icicle-search-lines') or M-s M-s M-s
(`icicle-search-generic').

But that's not my point.  There are lots of people that use both Gnus
and Icicles.  And for all of them, currently
`gnus-summary-search-article-forward' is by default not reachable by any
key in the summary buffer, and thus e.g. not "discoverable" with C-h b
or C-h w.

Of course I'm open to other suggestions than mine, but IMHO this binding
conflict should be solved in one way or another.


Thanks,

Michael.

Message #18 received at 11248 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 11248 <at> debbugs.gnu.org
Subject: Re: bug#11248: Problems with article search Keys in Summary
Date: Tue, 25 Dec 2012 17:58:04 +0100

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

>> Are there any icicles-mode commands that are useful in the summary
>> buffer?
>
> Icicles uses M-s M-s as a prefix for all its several search commands -
> no doubt some of them could indeed be useful in the summary buffer,
> e.g. M-s M-s l (`icicle-search-lines') or M-s M-s M-s
> (`icicle-search-generic').
>
> But that's not my point.

But that's my point.  If the icicles commands aren't useful in the Gnus
buffers, then switching icicles on in those buffers is the wrong thing
to do.

> There are lots of people that use both Gnus and Icicles.  And for all
> of them, currently `gnus-summary-search-article-forward' is by default
> not reachable by any key in the summary buffer, and thus e.g. not
> "discoverable" with C-h b or C-h w.
>
> Of course I'm open to other suggestions than mine, but IMHO this binding
> conflict should be solved in one way or another.

Well, `M-s' isn't going to change in Gnus.  It's been that way forever.

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Lars Magne Ingebrigtsen

Message #21 received at 11248 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 11248 <at> debbugs.gnu.org
Subject: Re: bug#11248: Problems with article search Keys in Summary
Date: Tue, 25 Dec 2012 19:04:48 +0100

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Michael Heerdegen <michael_heerdegen <at> web.de> writes:
>
> >> Are there any icicles-mode commands that are useful in the summary
> >> buffer?
> >
> > Icicles uses M-s M-s as a prefix for all its several search commands -
> > no doubt some of them could indeed be useful in the summary buffer,
> > e.g. M-s M-s l (`icicle-search-lines') or M-s M-s M-s
> > (`icicle-search-generic').
> >
> > But that's not my point.
>
> But that's my point.  If the icicles commands aren't useful in the Gnus
> buffers, then switching icicles on in those buffers is the wrong thing
> to do.

But `icicle-mode' is a _global_ minor mode.  It's typically on for a
whole session.  Users can't use your M-s binding _all_the_time_!

Once you understood that there is really a problem for users, and decide
not to change anything, I'm ok.

> > There are lots of people that use both Gnus and Icicles.  And for all
> > of them, currently `gnus-summary-search-article-forward' is by default
> > not reachable by any key in the summary buffer, and thus e.g. not
> > "discoverable" with C-h b or C-h w.
> >
> > Of course I'm open to other suggestions than mine, but IMHO this binding
> > conflict should be solved in one way or another.
>
> Well, `M-s' isn't going to change in Gnus.  It's been that way
> forever.

Ok, it's your decision.

How about using C-S and C-R as alternative bindings, as I suggested?


Regards,

Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.