GNU bug report logs - #11104
24.0.94; (void-function make-local-hook): Update NEWS maybe?

Previous Next

Package: emacs;

Reported by: Jambunathan K <kjambunathan <at> gmail.com>

Date: Tue, 27 Mar 2012 20:20:01 UTC

Severity: minor

Tags: wontfix

Merged with 7236

Found in versions 24.0.50, 24.0.94

Done: Lars Magne Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11104 in the body.
You can then email your comments to 11104 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Tue, 27 Mar 2012 20:20:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Jambunathan K <kjambunathan <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 27 Mar 2012 20:20:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jambunathan K <kjambunathan <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.94; (void-function make-local-hook): Update NEWS maybe?
Date: Wed, 28 Mar 2012 01:17:21 +0530
Debugger entered--Lisp error: (void-function make-local-hook)
  make-local-hook(kill-buffer-hook)
  dictionary-mode()
  dictionary()
  dictionary-ensure-buffer()
  dictionary-new-search((nil . "!"))
  dictionary-lookup-definition()
  call-interactively(dictionary-lookup-definition t nil)
  execute-extended-command(nil)
  call-interactively(execute-extended-command nil nil)

Library is file ~/elisp/dictionary-1.8.7/dictionary.elc

I understand that this is a third party library and possibly no longer
maintained. (See http://me.in-berlin.de/~myrkr/dictionary/download.html)

I see the following reference to `make-local-hook' in NEWS but it
doesn't help much.  

,---- C-h n
| * Incompatible Lisp Changes in Emacs 24.
| make-local-hook (not needed),
`----

Any workaround I can put locally in dictionary?



In GNU Emacs 24.0.94.1 (i386-mingw-nt5.1.2600)
 of 2012-03-19 on MARVIN
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.6) --no-opt --enable-checking --cflags
 -ID:/devel/emacs/libs/libXpm-3.5.8/include
 -ID:/devel/emacs/libs/libXpm-3.5.8/src
 -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
 -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
 -ID:/devel/emacs/libs/giflib-4.1.4-1/include
 -ID:/devel/emacs/libs/jpeg-6b-4/include
 -ID:/devel/emacs/libs/tiff-3.8.2-1/include
 -ID:/devel/emacs/libs/gnutls-3.0.9/include'





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Tue, 27 Mar 2012 20:29:07 GMT) Full text and rfc822 format available.

Message #8 received at 11104 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Jambunathan K <kjambunathan <at> gmail.com>
Cc: 11104 <at> debbugs.gnu.org
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Tue, 27 Mar 2012 15:57:00 -0400
Jambunathan K wrote:

> Any workaround I can put locally in dictionary?

Delete any calls to make-local-hook. They are... not needed.
They do nothing (since Emacs 21.1).




Forcibly Merged 7236 11104. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Tue, 27 Mar 2012 20:32:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Tue, 27 Mar 2012 20:52:01 GMT) Full text and rfc822 format available.

Message #13 received at 11104 <at> debbugs.gnu.org (full text, mbox):

From: Jambunathan K <kjambunathan <at> gmail.com>
To: 11104 <at> debbugs.gnu.org
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Wed, 28 Mar 2012 01:49:47 +0530
Glenn Morris <rgm <at> gnu.org> writes:

> Jambunathan K wrote:
>
>> Any workaround I can put locally in dictionary?
>
> Delete any calls to make-local-hook. They are... not needed.
> They do nothing (since Emacs 21.1).

Ahhh, the comment is too succinct and I got confused.

For the sake of record, I have done this.

  (defalias 'make-local-hook 'ignore)




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Wed, 28 Mar 2012 00:19:02 GMT) Full text and rfc822 format available.

Message #16 received at 11104 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> altern.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 11104 <at> debbugs.gnu.org, Jambunathan K <kjambunathan <at> gmail.com>
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Tue, 27 Mar 2012 22:02:07 +0200
Glenn Morris <rgm <at> gnu.org> writes:

> Jambunathan K wrote:
>
>> Any workaround I can put locally in dictionary?
>
> Delete any calls to make-local-hook. They are... not needed.
> They do nothing (since Emacs 21.1).

Comment to my previous message in this thread:

(defalias 'make-local-hook
  (if (featurep 'xemacs)
      'make-local-hook
    'ignore))

is actually the same function that `gnus-make-local-hook'. 

Adding the defalias above is a more generalized backward-compatibility
fix that other packages than Gnus would be aware of.  Should we add it
to Emacs?

-- 
 Bastien




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Wed, 28 Mar 2012 00:19:02 GMT) Full text and rfc822 format available.

Message #19 received at 11104 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> altern.org>
To: Jambunathan K <kjambunathan <at> gmail.com>
Cc: 11104 <at> debbugs.gnu.org
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Tue, 27 Mar 2012 22:00:18 +0200
Hi Jambunathan,

Jambunathan K <kjambunathan <at> gmail.com> writes:

> Debugger entered--Lisp error: (void-function make-local-hook)
>   make-local-hook(kill-buffer-hook)
>   dictionary-mode()
>   dictionary()
>   dictionary-ensure-buffer()
>   dictionary-new-search((nil . "!"))
>   dictionary-lookup-definition()
>   call-interactively(dictionary-lookup-definition t nil)
>   execute-extended-command(nil)
>   call-interactively(execute-extended-command nil nil)
>
> Library is file ~/elisp/dictionary-1.8.7/dictionary.elc
>
> I understand that this is a third party library and possibly no longer
> maintained. (See http://me.in-berlin.de/~myrkr/dictionary/download.html)
>
> I see the following reference to `make-local-hook' in NEWS but it
> doesn't help much.  
>
> ,---- C-h n
> | * Incompatible Lisp Changes in Emacs 24.
> | make-local-hook (not needed),
> `----
>
> Any workaround I can put locally in dictionary?

You can use this:

(defalias 'make-local-hook
  (if (featurep 'xemacs)
      'make-local-hook
    'ignore))

Perhaps this should be added to Emacs, I've seen another
packages that break only because of this.

-- 
 Bastien




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Wed, 28 Mar 2012 10:38:01 GMT) Full text and rfc822 format available.

Message #22 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Wed, 28 Mar 2012 18:05:35 +0800
On 2012-03-28 04:02 +0800, Bastien wrote:
> Adding the defalias above is a more generalized backward-compatibility
> fix that other packages than Gnus would be aware of.  Should we add it
> to Emacs?

Why add it back? I think we should let those packages do it in their own
name space.

Leo





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Wed, 28 Mar 2012 11:00:02 GMT) Full text and rfc822 format available.

Message #25 received at 11104 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> altern.org>
To: Leo <sdl.web <at> gmail.com>
Cc: 11104 <at> debbugs.gnu.org
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Wed, 28 Mar 2012 12:29:20 +0200
Leo <sdl.web <at> gmail.com> writes:

> On 2012-03-28 04:02 +0800, Bastien wrote:
>> Adding the defalias above is a more generalized backward-compatibility
>> fix that other packages than Gnus would be aware of.  Should we add it
>> to Emacs?
>
> Why add it back? I think we should let those packages do it in their own
> name space.

When it's for XEmacs compatibility I agree.

But this single line

  (defalias 'make-local-hook 'ignore)

if added to Emacs, would be of great help for users who don't 
know what's wrong.

-- 
 Bastien




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Wed, 28 Mar 2012 11:36:02 GMT) Full text and rfc822 format available.

Message #28 received at 11104 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Bastien <bzg <at> altern.org>
Cc: 11104 <at> debbugs.gnu.org, Leo <sdl.web <at> gmail.com>
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Wed, 28 Mar 2012 13:03:31 +0200
Bastien <bzg <at> altern.org> writes:

> But this single line
>
>   (defalias 'make-local-hook 'ignore)

This is wrong.  It should be identity instead.

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Wed, 28 Mar 2012 12:01:01 GMT) Full text and rfc822 format available.

Message #31 received at 11104 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> altern.org>
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: 11104 <at> debbugs.gnu.org, Leo <sdl.web <at> gmail.com>
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Wed, 28 Mar 2012 13:30:00 +0200
Andreas Schwab <schwab <at> linux-m68k.org> writes:

> Bastien <bzg <at> altern.org> writes:
>
>> But this single line
>>
>>   (defalias 'make-local-hook 'ignore)
>
> This is wrong.  It should be identity instead.

Why?

-- 
 Bastien




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Wed, 28 Mar 2012 12:15:01 GMT) Full text and rfc822 format available.

Message #34 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Wed, 28 Mar 2012 19:42:06 +0800
On 2012-03-28 18:29 +0800, Bastien wrote:
> When it's for XEmacs compatibility I agree.
> 
> But this single line
>
>   (defalias 'make-local-hook 'ignore)
>
> if added to Emacs, would be of great help for users who don't 
> know what's wrong.

,----
| This function is obsolete since 21.1; not necessary any more.
`----

It was removed for some time now and some code might be dependent on its
removal already. So add it back is not an option.

(unless (fboundp 'make-local-hook)
   .....)

Leo





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Wed, 28 Mar 2012 13:11:01 GMT) Full text and rfc822 format available.

Message #37 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Wed, 28 Mar 2012 20:38:31 +0800
On 2012-03-28 19:30 +0800, Bastien wrote:
> Why?

Check the documentation on the return value.

Leo





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Wed, 28 Mar 2012 13:20:02 GMT) Full text and rfc822 format available.

Message #40 received at 11104 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Leo'" <sdl.web <at> gmail.com>, <11104 <at> debbugs.gnu.org>
Subject: RE: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Wed, 28 Mar 2012 05:47:56 -0700
> Why add it back? I think we should let those packages do it 
> in their own name space.

It seems to be part of GNU Emacs already, albeit in Gnusland.
And maybe soon in Orgland as well?

Or are you suggesting that Gnus (& Org...) be removed
from Emacs?  Relegated to Elpagatory perhaps?  ;-)
(Sure, why not?)





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Wed, 28 Mar 2012 13:51:02 GMT) Full text and rfc822 format available.

Message #43 received at 11104 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> altern.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 11104 <at> debbugs.gnu.org, 'Leo' <sdl.web <at> gmail.com>
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Wed, 28 Mar 2012 15:20:01 +0200
"Drew Adams" <drew.adams <at> oracle.com> writes:

>> Why add it back? I think we should let those packages do it 
>> in their own name space.
>
> It seems to be part of GNU Emacs already, albeit in Gnusland.
> And maybe soon in Orgland as well?

And Gnus defines it using 'ignore.  

I've check the docstrings of 'ignore and 'identity and I still
don't understand why 'identity should be used instead of 'ignore
(as Gnus does).

Any useful hint?

-- 
 Bastien




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Wed, 28 Mar 2012 14:54:02 GMT) Full text and rfc822 format available.

Message #46 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Wed, 28 Mar 2012 22:21:33 +0800
......
This function is obsolete since 21.1;
not necessary any more.

Make the hook HOOK local to the current buffer.
The return value is HOOK.
                    ^
                    +----- see?

Leo





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Wed, 28 Mar 2012 15:03:02 GMT) Full text and rfc822 format available.

Message #49 received at 11104 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> altern.org>
To: Leo <sdl.web <at> gmail.com>
Cc: 11104 <at> debbugs.gnu.org
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Wed, 28 Mar 2012 16:31:21 +0200
Leo <sdl.web <at> gmail.com> writes:

> ......
> This function is obsolete since 21.1;
> not necessary any more.
>
> Make the hook HOOK local to the current buffer.
> The return value is HOOK.
>                     ^
>                     +----- see?

No, I don't see.  Can you be more explicit?

-- 
 Bastien




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Wed, 28 Mar 2012 15:08:02 GMT) Full text and rfc822 format available.

Message #52 received at 11104 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Bastien <bzg <at> altern.org>
Cc: 11104 <at> debbugs.gnu.org, 'Leo' <sdl.web <at> gmail.com>,
	Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Wed, 28 Mar 2012 16:35:18 +0200
Bastien <bzg <at> altern.org> writes:

> And Gnus defines it using 'ignore.  

It doesn't.  It defines gnus-make-local-hook.

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Wed, 28 Mar 2012 15:22:01 GMT) Full text and rfc822 format available.

Message #55 received at 11104 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> altern.org>
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: 11104 <at> debbugs.gnu.org, 'Leo' <sdl.web <at> gmail.com>,
	Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Wed, 28 Mar 2012 16:42:46 +0200
Andreas Schwab <schwab <at> linux-m68k.org> writes:

> Bastien <bzg <at> altern.org> writes:
>
>> And Gnus defines it using 'ignore.  
>
> It doesn't.  It defines gnus-make-local-hook.

This is in gnus-utils.el:

;; The LOCAL arg to `add-hook' is interpreted differently in Emacs and
;; XEmacs.  In Emacs we don't need to call `make-local-hook' first.
;; It's harmless, though, so the main purpose of this alias is to shut
;; up the byte compiler.
(defalias 'gnus-make-local-hook (if (featurep 'xemacs)
                                    'make-local-hook
                                  'ignore))

IIUC, you think it should be

(defalias 'gnus-make-local-hook (if (featurep 'xemacs)
                                    'make-local-hook
                                  'identity))

right?

-- 
 Bastien




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Wed, 28 Mar 2012 15:52:01 GMT) Full text and rfc822 format available.

Message #58 received at 11104 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Bastien <bzg <at> altern.org>
Cc: 11104 <at> debbugs.gnu.org, 'Leo' <sdl.web <at> gmail.com>,
	Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Wed, 28 Mar 2012 17:20:11 +0200
Bastien <bzg <at> altern.org> writes:

> IIUC, you think it should be
>
> (defalias 'gnus-make-local-hook (if (featurep 'xemacs)
>                                     'make-local-hook
>                                   'identity))
>
> right?

No.

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Wed, 28 Mar 2012 15:55:02 GMT) Full text and rfc822 format available.

Message #61 received at 11104 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> altern.org>
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: 11104 <at> debbugs.gnu.org, 'Leo' <sdl.web <at> gmail.com>,
	Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Wed, 28 Mar 2012 17:24:45 +0200
Andreas Schwab <schwab <at> linux-m68k.org> writes:

> Bastien <bzg <at> altern.org> writes:
>
>> IIUC, you think it should be
>>
>> (defalias 'gnus-make-local-hook (if (featurep 'xemacs)
>>                                     'make-local-hook
>>                                   'identity))
>>
>> right?
>
> No.

You said:

>>   (defalias 'make-local-hook 'ignore)
>
>This is wrong.  It should be identity instead.

So you are suggesting 

(defalias 'make-local-hook 'ignore)

should be

(defalias 'make-local-hook 'identity)

instead.

Am I right?

-- 
 Bastien, trying to communicate with a sphinx




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Wed, 28 Mar 2012 16:03:02 GMT) Full text and rfc822 format available.

Message #64 received at 11104 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Bastien <bzg <at> altern.org>
Cc: 11104 <at> debbugs.gnu.org, Andreas Schwab <schwab <at> linux-m68k.org>,
	Leo <sdl.web <at> gmail.com>
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Wed, 28 Mar 2012 17:30:50 +0200
On Wed, Mar 28, 2012 at 17:24, Bastien <bzg <at> altern.org> wrote:
> Andreas Schwab <schwab <at> linux-m68k.org> writes:
>
>> Bastien <bzg <at> altern.org> writes:
>>
>>> IIUC, you think it should be
>>>
>>> (defalias 'gnus-make-local-hook (if (featurep 'xemacs)
>>>                                     'make-local-hook
>>>                                   'identity))
>>>
>>> right?
>>
>> No.

:-)  -- This kind of humourness is hard on the internet. I am glad
when it is seen as humour.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Wed, 28 Mar 2012 22:30:02 GMT) Full text and rfc822 format available.

Message #67 received at 11104 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> altern.org>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 11104 <at> debbugs.gnu.org, Andreas Schwab <schwab <at> linux-m68k.org>,
	Leo <sdl.web <at> gmail.com>
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Wed, 28 Mar 2012 23:59:34 +0200
Lennart Borgman <lennart.borgman <at> gmail.com> writes:

> :-)  -- This kind of humourness is hard on the internet. I am glad
> when it is seen as humour.

I see it as such.  But I still don't understand why we should use 

(defalias 'make-local-hook 'identity)

instead of 

(defalias 'make-local-hook 'ignore)

Life is full of mysteries, that's alright.

-- 
 Bastien




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Wed, 28 Mar 2012 22:32:01 GMT) Full text and rfc822 format available.

Message #70 received at 11104 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Bastien <bzg <at> altern.org>
Cc: 11104 <at> debbugs.gnu.org, Andreas Schwab <schwab <at> linux-m68k.org>,
	Leo <sdl.web <at> gmail.com>
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Wed, 28 Mar 2012 23:59:46 +0200
On Wed, Mar 28, 2012 at 23:59, Bastien <bzg <at> altern.org> wrote:
> Lennart Borgman <lennart.borgman <at> gmail.com> writes:
>
>> :-)  -- This kind of humourness is hard on the internet. I am glad
>> when it is seen as humour.
>
> I see it as such.  But I still don't understand why we should use
>
> (defalias 'make-local-hook 'identity)
>
> instead of
>
> (defalias 'make-local-hook 'ignore)
>
> Life is full of mysteries, that's alright.

Just to be backward compatible, or?




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Thu, 29 Mar 2012 07:43:01 GMT) Full text and rfc822 format available.

Message #73 received at 11104 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> altern.org>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 11104 <at> debbugs.gnu.org, Andreas Schwab <schwab <at> linux-m68k.org>,
	Leo <sdl.web <at> gmail.com>
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Thu, 29 Mar 2012 09:11:38 +0200
Lennart Borgman <lennart.borgman <at> gmail.com> writes:

> On Wed, Mar 28, 2012 at 23:59, Bastien <bzg <at> altern.org> wrote:
>> Lennart Borgman <lennart.borgman <at> gmail.com> writes:
>>
>>> :-)  -- This kind of humourness is hard on the internet. I am glad
>>> when it is seen as humour.
>>
>> I see it as such.  But I still don't understand why we should use
>>
>> (defalias 'make-local-hook 'identity)
>>
>> instead of
>>
>> (defalias 'make-local-hook 'ignore)
>>
>> Life is full of mysteries, that's alright.
>
> Just to be backward compatible, or?

Yes.  The `gnus-make-local-hook' uses the 'ignore function for its
backward-compatibility function.  The Sphinx said we should use
'identity for the defalias.  So I'm a bit loss.  But that's okay,
I can live with it.

-- 
 Bastien




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Thu, 29 Mar 2012 13:23:02 GMT) Full text and rfc822 format available.

Message #76 received at 11104 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Bastien <bzg <at> altern.org>
Cc: Andreas Schwab <schwab <at> linux-m68k.org>,
	Lennart Borgman <lennart.borgman <at> gmail.com>,
	Leo <sdl.web <at> gmail.com>, 11104 <at> debbugs.gnu.org
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Thu, 29 Mar 2012 08:50:33 -0400
> Yes.  The `gnus-make-local-hook' uses the 'ignore function for its
> backward-compatibility function.  The Sphinx said we should use
> 'identity for the defalias.  So I'm a bit loss.  But that's okay,
> I can live with it.

To be backward compatible, a redefinition of make-local-hook should use
`identity' so as to return the same value as the old definition did.
For gnus-make-local-hook that's not necessary because Gnus's code
doesn't use the return value of make-local-hook.


        Stefan




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11104; Package emacs. (Wed, 04 Apr 2012 08:30:02 GMT) Full text and rfc822 format available.

Message #79 received at 11104 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> altern.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Andreas Schwab <schwab <at> linux-m68k.org>,
	Lennart Borgman <lennart.borgman <at> gmail.com>,
	Leo <sdl.web <at> gmail.com>, 11104 <at> debbugs.gnu.org
Subject: Re: bug#11104: 24.0.94;
	(void-function make-local-hook): Update NEWS maybe?
Date: Wed, 04 Apr 2012 10:30:24 +0200
Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> Yes.  The `gnus-make-local-hook' uses the 'ignore function for its
>> backward-compatibility function.  The Sphinx said we should use
>> 'identity for the defalias.  So I'm a bit loss.  But that's okay,
>> I can live with it.
>
> To be backward compatible, a redefinition of make-local-hook should use
> `identity' so as to return the same value as the old definition did.
> For gnus-make-local-hook that's not necessary because Gnus's code
> doesn't use the return value of make-local-hook.

Got it, thanks.

-- 
 Bastien




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 02 May 2012 11:24:03 GMT) Full text and rfc822 format available.

This bug report was last modified 13 years and 106 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.