GNU bug report logs - #10937
24.0.94; fix savehist-printable

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo <sdl.web <at> gmail.com>
Subject: bug#10937: closed (Re: bug#10937: 24.0.94; fix savehist-printable)
Date: Fri, 09 Mar 2012 18:14:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#10937: 24.0.94; fix savehist-printable

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 10937 <at> debbugs.gnu.org.

-- 
10937: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10937
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Leo <sdl.web <at> gmail.com>
To: 10937-done <at> debbugs.gnu.org
Subject: Re: bug#10937: 24.0.94; fix savehist-printable
Date: Sat, 10 Mar 2012 02:12:26 +0800

Fixed in 24.0.95.

[Message part 3 (message/rfc822, inline)]

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.94; fix savehist-printable
Date: Sun, 04 Mar 2012 17:15:44 +0800

In savehist-printable, strings are not necessary printable. They can
contain anything in their properties. Because of this I have kill-ring
emptied for almost every restart of emacs.

I propose:

diff --git a/lisp/savehist.el b/lisp/savehist.el
index c1515fa4..a3ba9f1a 100644
--- a/lisp/savehist.el
+++ b/lisp/savehist.el
@@ -369,7 +369,7 @@ (defun savehist-printable (value)
   "Return non-nil if VALUE is printable."
   (cond
    ;; Quick response for oft-encountered types known to be printable.
-   ((stringp value))
+   ((equal-including-properties value (substring-no-properties value)))
    ((numberp value))
    ((symbolp value))
    (t

or just remove (stringp value) and let the default handle it.

Leo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.