GNU bug report logs - #10938
procedure-arguments return differnet output when procedure-property is used

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10938 in the body.
You can then email your comments to 10938 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Israelsson Tampe <stefan.itampe <at> gmail.com>
To: bug-guile <at> gnu.org
Subject: procedure-arguments return differnet output when procedure-property
	is used
Date: Sun, 4 Mar 2012 13:15:47 +0100

[Message part 1 (text/plain, inline)]

Typeically in guile

> (procedure-arguments g)
$3 = ((required x) (optional) (keyword) (allow-other-keys? . #f) (rest .
#f))

for a program g. But if we attach a procedure property 'arglist the outpu
is acording to (system ice-9 session),
(define (procedure-arguments proc)
  "Return an alist describing the arguments that `proc' accepts, or `#f'
if the information cannot be obtained.

The alist keys that are currently defined are `required', `optional',
`keyword', and `rest'."
  (cond
   ((procedure-property proc 'arglist)
    => (lambda (arglist)
         `((required . ,(car arglist))
           (optional . ,(cadr arglist))
           (keyword . ,(caddr arglist))
           (allow-other-keys? . ,(cadddr arglist))
           (rest . ,(car (cddddr arglist))))))
   ((procedure-source proc)
    => cadr)
   (((@ (system vm program) program?) proc)
    ((@ (system vm program) program-arguments-alist) proc))
   (else #f)))

Acording to the description allow-other-keys? is not included, but returned
for a program
but not of prop 'arglist is used, so either

1. drop allow-other-keys? from the program? version or add it to the proper
version and change doc string

Regards
Stefan

[Message part 2 (text/html, inline)]

Message #8 received at 10938 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Israelsson Tampe <stefan.itampe <at> gmail.com>
To: 10938 <at> debbugs.gnu.org
Subject: patch
Date: Sun, 4 Mar 2012 13:23:58 +0100

[Message part 1 (text/plain, inline)]

Sorry I posted a version of session.scm with a prtly fix included
anyway here is a patch where we add allow-other-keys?

[Message part 2 (text/html, inline)]

[session.diff (text/x-patch, attachment)]

Message #11 received at 10938 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Stefan Israelsson Tampe <stefan.itampe <at> gmail.com>
Cc: 10938 <at> debbugs.gnu.org
Subject: Re: bug#10938: patch
Date: Mon, 05 Mar 2012 17:59:33 +0100

Hi Stefan,

Stefan Israelsson Tampe <stefan.itampe <at> gmail.com> skribis:

> diff --git a/module/ice-9/session.scm b/module/ice-9/session.scm
> index fbb03d2..dc2c927 100644
> --- a/module/ice-9/session.scm
> +++ b/module/ice-9/session.scm
> @@ -504,13 +504,14 @@ It is an image under the mapping EXTRACT."
>  if the information cannot be obtained.
>  
>  The alist keys that are currently defined are `required', `optional',
> -`keyword', and `rest'."
> +`keyword', allow-other-keys? and `rest'."
>    (cond
>     ((procedure-property proc 'arglist)
>      => (lambda (arglist)
>           `((required . ,(car arglist))
>             (optional . ,(cadr arglist))
>             (keyword . ,(caddr arglist))
> +           (allow-other-keys? . ,(cadddr arglist))
>             (rest . ,(car (cddddr arglist))))))
>     ((procedure-source proc)
>      => cadr)

Can you provide one or more test cases that illustrate that this patch
fixes?

Also, please send your patch in ‘git format-patch’ format.

Thanks,
Ludo’.

Message #14 received at 10938 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Israelsson Tampe <stefan.itampe <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 10938 <at> debbugs.gnu.org
Subject: Re: bug#10938: patch
Date: Sat, 10 Mar 2012 16:40:49 +0100

[Message part 1 (text/plain, inline)]

Following this email is the requested patch format

Test case.
With the patch:

(define (f x) x)
(define arg1 (procedure-arguments f))
(set-procedure-property! f 'arglist (map cdr arg1))
(define arg2 (procedure-arguments f))
(equal? arg1 arg2)
$4 = #t

Without the patch a field is missing and the result would be #f

/Stefan


2012/3/5 Ludovic Courtès <ludo <at> gnu.org>

> Hi Stefan,
>
> Stefan Israelsson Tampe <stefan.itampe <at> gmail.com> skribis:
>
> > diff --git a/module/ice-9/session.scm b/module/ice-9/session.scm
> > index fbb03d2..dc2c927 100644
> > --- a/module/ice-9/session.scm
> > +++ b/module/ice-9/session.scm
> > @@ -504,13 +504,14 @@ It is an image under the mapping EXTRACT."
> >  if the information cannot be obtained.
> >
> >  The alist keys that are currently defined are `required', `optional',
> > -`keyword', and `rest'."
> > +`keyword', allow-other-keys? and `rest'."
> >    (cond
> >     ((procedure-property proc 'arglist)
> >      => (lambda (arglist)
> >           `((required . ,(car arglist))
> >             (optional . ,(cadr arglist))
> >             (keyword . ,(caddr arglist))
> > +           (allow-other-keys? . ,(cadddr arglist))
> >             (rest . ,(car (cddddr arglist))))))
> >     ((procedure-source proc)
> >      => cadr)
>
> Can you provide one or more test cases that illustrate that this patch
> fixes?
>
> Also, please send your patch in ‘git format-patch’ format.
>
> Thanks,
> Ludo’.
>

[Message part 2 (text/html, inline)]

[session.patch (text/x-patch, attachment)]

Message #19 received at 10938-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Stefan Israelsson Tampe <stefan.itampe <at> gmail.com>
Cc: 10938-done <at> debbugs.gnu.org
Subject: Re: bug#10938: patch
Date: Mon, 02 Jul 2012 15:11:30 +0200

Hi Stefan,

Thanks, fixed differently in a8215aedad433a15abf87c2310a41c684dfcef97.

In the future, could you please provide a patch with a log and test case
similar to what’s in the above commit?

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.