GNU bug report logs - #10937
24.0.94; fix savehist-printable

Previous Next

Package: emacs;

Reported by: Leo <sdl.web <at> gmail.com>

Date: Sun, 4 Mar 2012 09:18:02 UTC

Severity: normal

Found in version 24.0.94

Done: Leo <sdl.web <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo <sdl.web <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#10937: closed (24.0.94; fix savehist-printable)
Date: Fri, 09 Mar 2012 18:14:01 +0000

[Message part 1 (text/plain, inline)]
Your message dated Sat, 10 Mar 2012 02:12:26 +0800
with message-id <m18vj9wsmt.fsf <at> gmail.com>
and subject line Re: bug#10937: 24.0.94; fix savehist-printable
has caused the debbugs.gnu.org bug report #10937,
regarding 24.0.94; fix savehist-printable
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
10937: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10937
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]
From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.94; fix savehist-printable
Date: Sun, 04 Mar 2012 17:15:44 +0800

In savehist-printable, strings are not necessary printable. They can
contain anything in their properties. Because of this I have kill-ring
emptied for almost every restart of emacs.

I propose:

diff --git a/lisp/savehist.el b/lisp/savehist.el
index c1515fa4..a3ba9f1a 100644
--- a/lisp/savehist.el
+++ b/lisp/savehist.el
@@ -369,7 +369,7 @@ (defun savehist-printable (value)
   "Return non-nil if VALUE is printable."
   (cond
    ;; Quick response for oft-encountered types known to be printable.
-   ((stringp value))
+   ((equal-including-properties value (substring-no-properties value)))
    ((numberp value))
    ((symbolp value))
    (t

or just remove (stringp value) and let the default handle it.

Leo



[Message part 3 (message/rfc822, inline)]
From: Leo <sdl.web <at> gmail.com>
To: 10937-done <at> debbugs.gnu.org
Subject: Re: bug#10937: 24.0.94; fix savehist-printable
Date: Sat, 10 Mar 2012 02:12:26 +0800

Fixed in 24.0.95.
This bug report was last modified 13 years and 148 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.