GNU bug report logs - #1092
compilation-goto-error goes to wrong location when buffer has hidden regions

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#1092: closed (compilation-goto-error goes to wrong location
 when buffer has hidden regions)
Date: Sun, 03 Jan 2016 15:27:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 03 Jan 2016 17:25:53 +0200
with message-id <83poxiadmm.fsf <at> gnu.org>
and subject line Re: bug#1092: compilation-goto-error goes to wrong location when buffer has hidden regions
has caused the debbugs.gnu.org bug report #1092,
regarding compilation-goto-error goes to wrong location when buffer has hidden regions
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
1092: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=1092
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Peter Sanford <pms.mail <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: compilation-goto-error goes to wrong location when buffer has hidden
 regions
Date: Sun, 05 Oct 2008 11:38:08 -0700

I have the copyright region at the head of my files hidden using 
selective-display and ^M. When this region is hidden functions like 
compilation-goto-error jump to the wrong location: n lines below the 
correct location where n is the number of hidden lines. If I use 
goto-line and the line number reported in the compilation buffer, emacs 
takes me to the correct line.

When the region is visible everything works as expected.

found on:
GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.14.1) of 2008-09-05 
on vernadsky, modified by Ubuntu

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: ahyatt <at> gmail.com, 1092-done <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#1092: compilation-goto-error goes to wrong location when
 buffer has hidden regions
Date: Sun, 03 Jan 2016 17:25:53 +0200

[Message part 4 (text/plain, inline)]

> From: Glenn Morris <rgm <at> gnu.org>
> Cc: Andrew Hyatt <ahyatt <at> gmail.com>,  1092 <at> debbugs.gnu.org,  monnier <at> iro.umontreal.ca
> Date: Sat, 02 Jan 2016 23:06:15 -0500
> 
> I'm not going to give a recipe for a bug that I marked wontfix 7 years
> ago, and which has recently been closed. If no-one cares enough to
> follow the original example, no one is going to fix it.

(There was no example in the original report, not AFAICT.)

I think Andrew just wanted to DTRT with this bug, which is
commendable, IMO.

I came up with a simple example, see below.

> Selective display is 7 years more obsolete than it was then. Let's
> move on.

I see no reason not to fix this simple bug, so I just did it.

Here's a reproducible recipe, for the record:

 . Visit the attached file
 . Replace every C-j in the commentary block with a C-m
 . M-: (setq selective-display t) RET
 . Save the buffer (note that the file on disk has its newlines
   restored by write-region -- I wonder how many people knew we had
   this feature in write-region)
 . M-x compile RET gcc -Wall -o hello hello.c RET
 . Type "C-x `" and observe the incorrect behavior: point in the
   hello.c buffer goes to the end of the buffer, and the error
   locus is not highlighted

With the current emacs-25 branch, this example works correctly.

I'm marking this bug as done (after reopening it).

[hello.c (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.