GNU bug report logs - #10894
Mixed C-Vala projects distcheck is broken

Previous Next

Full log

Message #8 received at 10894 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Quentin Glidic <sardemff7+gnu <at> sardemff7.net>
Cc: 10894 <at> debbugs.gnu.org, automake-patches <at> gnu.org
Subject: Re: bug#10894: Mixed C-Vala projects distcheck is broken
Date: Mon, 27 Feb 2012 22:33:05 +0100

[Message part 1 (text/plain, inline)]

Hi Quentin, thanks for the report.

On 02/26/2012 10:12 PM, Quentin Glidic wrote:
> Package: automake
> Version: 1.11.3
> 
> Hello,
> 
> The distcheck of a project which mix C and Vala targets in the same Makefile.am
> leads to a pass of C targets to valac, which is completely wrong and fails if
> you put your headers in _SOURCES (valac ignores *.c files only).
>
This is bad.  We had a test in the automake testsuite that tried to build a
project with mixed C/Vala sources, but it didn't use a C header as well :-(

I've thus added a new test case that exposes the bug (see the first attached
patch).

> Attached a patch that limits the vala stamps’ generation to targets with
> *.vala file.
>
Unfortunately, your patch doesn't seem to fix the issue.  I've attached a
second patch that seems to do the trick.  It will appear in the next automake
version (1.12) unless there are objections.

Thanks,
  Stefano

[0001-vala-expose-automake-bug-10894.patch (text/x-diff, attachment)]

[0002-vala-fix-valac-calls-for-projects-with-mixed-Vala-C.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.